pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
7+ messages / 1 participants
[nested] [flat]
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8318f2b170d81e6792b90f2aa2b491a2b7add441
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5bd26e6527800749641dcb6a4409c0eb0ec1ba8d
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/eba8cc1af8ec57aff99f11ef9cdf24a641c159b0
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6d047c6a9192df34670a503c4d289a93e4909033
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ce6f27857bba9e380a10365abf798dfbf453cc31
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d4ade0bafb7571c8268f5eae4124e71df45ca8b2
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus
@ 2024-10-07 21:50 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: Nathan Bossart @ 2024-10-07 21:50 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit 1ab67c9dfa, which modified this catalog query so that it
doesn't return temporary relations, forgot to schema-qualify the
operator. A comment earlier in the function implores us to fully
qualify everything in the query:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
This commit fixes that. While at it, add a newline for consistency
with surrounding code.
Reviewed-by: Noah Misch
Discussion: https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathan
Backpatch-through: 12
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5e0431c32a8f723fcf5b0eea77a4b6144b6abdff
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-10-07 21:50 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
2024-10-07 21:50 pgsql: vacuumdb: Schema-qualify operator in catalog query's WHERE claus Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox