pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove incorrect function import from pgindent
7+ messages / 1 participants
[nested] [flat]

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:41 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4528fdfa903c74cf99837a554bd3c7e115bb366

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:41 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c5b9097255ba70eed9ffe3d804453c80dc1a79f0

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:42 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f21e51ea73973f87715581fc68a6caf97f56505e

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:42 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/866e4a7d598b9edaddddd235df1414b746e37825

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:42 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4a75ff7afb4db0283cac79bff546369462890063

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:43 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/79ca063de8dace1ae0bb9774ca1f0480f4bcc73f

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Remove incorrect function import from pgindent
@ 2024-10-09 07:43 Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Daniel Gustafsson @ 2024-10-09 07:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove incorrect function import from pgindent

Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/610c65064732d25e7a0066ea49b56433b9c2cc4c

Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2024-10-09 07:43 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-10-09 07:41 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:41 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:42 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:42 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:42 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:43 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>
2024-10-09 07:43 pgsql: Remove incorrect function import from pgindent Daniel Gustafsson <dgustafsson@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox