pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/68ad9816c189958a0731d8d5ead7545878fdf15d Modified Files -------------- src/backend/commands/copyto.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6c3b2d204f2b02dd80357742713d47050af30613 Modified Files -------------- src/backend/commands/copyto.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6a57a457cf7d3409579868ef17de6725ec6e67ca Modified Files -------------- src/backend/commands/copy.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c80a1e0483970f88710469c5bfe55d5e48cf3bd7 Modified Files -------------- src/backend/commands/copyto.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5e94f616c8321a2e95986a236c10dfa26a3a844a Modified Files -------------- src/backend/commands/copyto.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/beab395a42b24f2049ad09b1d90ee9f218743d04 Modified Files -------------- src/backend/commands/copy.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" @ 2024-10-21 19:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-10-21 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix wrong assertion and poor error messages in "COPY (query) TO". If the query is rewritten into a NOTIFY command by a DO INSTEAD rule, we'd get an assertion failure, or in non-assert builds issue a rather confusing error message. Improve that. Also fix a longstanding grammar mistake in a nearby error message. Per bug #18664 from Alexander Lakhin. Back-patch to all supported branches. Tender Wang and Tom Lane Discussion: https://postgr.es/m/18664-ffd0ebc2386598df@postgresql.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3685ad6188c1697c8a685f8fabe79e508b0dcc6e Modified Files -------------- src/backend/commands/copyto.c | 8 ++++++-- src/test/regress/expected/copydml.out | 10 +++++++--- src/test/regress/sql/copydml.sql | 4 ++++ 3 files changed, 17 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-10-21 19:08 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us> 2024-10-21 19:08 pgsql: Fix wrong assertion and poor error messages in "COPY (query) TO" Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox