pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: WAL-log inplace update before revealing it to other sessions. 11+ messages / 1 participants [nested] [flat]
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8e7e672cdaa6bfec85d4d5dd9be84159df23bb41 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 ++++++++++++++++++++++++++-------- 2 files changed, 46 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bfd5c6e279c8e1702eea882439dc7ebdf4d4b3a5 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 ++++++++++++++++++++++++++-------- 2 files changed, 46 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/659903f8e792a96a098a593fe2d847755f34545d Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 ++++++++++++++++++++++++++-------- 2 files changed, 46 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/431e05181e4172415decf618ada8e91d6df995b1 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 ++++++++++++++++++++++++++-------- 2 files changed, 46 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/acf49584e2165ded5396d107961b568fe8f5f954 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 +++++++++++++++++++++++++-------- src/backend/access/transam/xloginsert.c | 2 -- 3 files changed, 46 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1e74e31f3c93f01c2ddb1e2b25db23fb0533244c Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 +++++++++++++++++++++++++-------- src/backend/access/transam/xloginsert.c | 2 -- 3 files changed, 46 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v12 (all supported versions). In v14 and earlier, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e30d0d8adf534453355024aae68b8b691c105b67 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +-- src/backend/access/heap/heapam.c | 58 +++++++++++++++++++++++++-------- src/backend/access/transam/xloginsert.c | 2 -- 3 files changed, 46 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2025-12-17 00:14 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2025-12-17 00:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v14 - v17. This is a back-patch of commits: - 8e7e672cdaa6bfec85d4d5dd9be84159df23bb41 (main change, on master, before v18 branched) - 818013665259d4242ba641aad705ebe5a3e2db8e (defect fix, on master, before v18 branched) It reverses commit bc6bad88572501aecaa2ac5d4bc900ac0fd457d5, my revert of the original back-patch. In v14, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Backpatch-through: 14-17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d3e5d89504484d69bc41e66fc2c2346ec0da6b07 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +- src/backend/access/heap/heapam.c | 68 +++++++++++++++++++++++++++------- src/include/storage/proc.h | 8 ++-- 3 files changed, 59 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2025-12-17 00:14 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2025-12-17 00:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v14 - v17. This is a back-patch of commits: - 8e7e672cdaa6bfec85d4d5dd9be84159df23bb41 (main change, on master, before v18 branched) - 818013665259d4242ba641aad705ebe5a3e2db8e (defect fix, on master, before v18 branched) It reverses commit bc6bad88572501aecaa2ac5d4bc900ac0fd457d5, my revert of the original back-patch. In v14, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Backpatch-through: 14-17 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/720e9304fa0d395d26f4218f4c13bfb868736ce8 Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +- src/backend/access/heap/heapam.c | 68 +++++++++++++++++++++++++++------- src/include/storage/proc.h | 8 ++-- 3 files changed, 59 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2025-12-17 00:14 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2025-12-17 00:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v14 - v17. This is a back-patch of commits: - 8e7e672cdaa6bfec85d4d5dd9be84159df23bb41 (main change, on master, before v18 branched) - 818013665259d4242ba641aad705ebe5a3e2db8e (defect fix, on master, before v18 branched) It reverses commit bc6bad88572501aecaa2ac5d4bc900ac0fd457d5, my revert of the original back-patch. In v14, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Backpatch-through: 14-17 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/20a48c156d6456cea648b04ca2c07143e603133e Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +- src/backend/access/heap/heapam.c | 68 +++++++++++++++++++++++++++------- src/include/storage/proc.h | 8 ++-- 3 files changed, 59 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: WAL-log inplace update before revealing it to other sessions. @ 2025-12-17 00:14 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 11+ messages in thread From: Noah Misch @ 2025-12-17 00:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org WAL-log inplace update before revealing it to other sessions. A buffer lock won't stop a reader having already checked tuple visibility. If a vac_update_datfrozenid() and then a crash happened during inplace update of a relfrozenxid value, datfrozenxid could overtake relfrozenxid. That could lead to "could not access status of transaction" errors. Back-patch to v14 - v17. This is a back-patch of commits: - 8e7e672cdaa6bfec85d4d5dd9be84159df23bb41 (main change, on master, before v18 branched) - 818013665259d4242ba641aad705ebe5a3e2db8e (defect fix, on master, before v18 branched) It reverses commit bc6bad88572501aecaa2ac5d4bc900ac0fd457d5, my revert of the original back-patch. In v14, this also back-patches the assertion removal from commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b. Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com Backpatch-through: 14-17 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e4b1986b9899fedc50c99738f85da39e65e4743f Modified Files -------------- src/backend/access/heap/README.tuplock | 4 +- src/backend/access/heap/heapam.c | 68 ++++++++++++++++++++++++++------- src/backend/access/transam/xloginsert.c | 2 - 3 files changed, 55 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2025-12-17 00:14 UTC | newest] Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2025-12-17 00:14 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2025-12-17 00:14 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2025-12-17 00:14 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com> 2025-12-17 00:14 pgsql: WAL-log inplace update before revealing it to other sessions. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox