pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Unpin buffer before inplace update waits for an XID to end. 7+ messages / 1 participants [nested] [flat]
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9aef6f19ac27a607f0c557d19934d5ce96ed5f1a Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/30d47ec8c6c78f46bcd7116b7effb6988b126e43 Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2a912bc1abdbaa2f73555cf2c71bb4c401aa515b Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0fe002d0c9a5b04bb676e9cb8f80325f7129b5f3 Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/11e3f288f3dbda8b460aba93e1c18b55017e7b08 Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/370bc7740286d342068ce8813ce87aaa4e97973a Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Unpin buffer before inplace update waits for an XID to end. @ 2024-10-29 16:41 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2024-10-29 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unpin buffer before inplace update waits for an XID to end. Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE. By keeping the pin during that wait, a sequence of autovacuum workers and an uncommitted GRANT starved one foreground LockBufferForCleanup() for six minutes, on buildfarm member sarus. Prevent, at the cost of a bit of complexity. Back-patch to v12, like the earlier commit. That commit and heap_inplace_lock() have not yet appeared in any release. Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c2139db11b161096c9d65a0fa7c1a8a3227ea856 Modified Files -------------- src/backend/access/heap/heapam.c | 10 +++++++--- src/backend/access/index/genam.c | 12 +++++------- src/include/access/heapam.h | 3 ++- 3 files changed, 14 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-10-29 16:41 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com> 2024-10-29 16:41 pgsql: Unpin buffer before inplace update waits for an XID to end. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox