pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Parallel workers use AuthenticatedUserId for connection privileg 7+ messages / 1 participants [nested] [flat]
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/73c9f91a1b6d3753451993c5f06ba4b5ccc1f127 Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f4f5d27d87247da1ec7e5a6e7990a22ffba9f63a Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/95f5a523729f6814c8757860d9a2264148b7b0df Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/109a323807d752f66699a9ce0762244f536e784f Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/00b94e8e2f99a8ed1d7f854838234ce37f582da0 Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dc7378793add3c3d9a40ec2118d92bd719acab97 Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Parallel workers use AuthenticatedUserId for connection privileg @ 2024-11-11 22:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2024-11-11 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Parallel workers use AuthenticatedUserId for connection privilege checks. Commit 5a2fed911 had an unexpected side-effect: the parallel worker launched for the new test case would fail if it couldn't use a superuser-reserved connection slot. The reason that test failed while all our pre-existing ones worked is that the connection privilege tests in InitPostgres had been based on the superuserness of the leader's AuthenticatedUserId, but after the rearrangements of 5a2fed911 we were testing the superuserness of CurrentUserId, which the new test case deliberately made to be a non-superuser. This all seems very accidental and probably not the behavior we really want, but a security patch is no time to be redesigning things. Pending some discussion about desirable semantics, hack it so that InitPostgres continues to pay attention to the superuserness of AuthenticatedUserId when starting a parallel worker. Nathan Bossart and Tom Lane, per buildfarm member sawshark. Security: CVE-2024-10978 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0edad8654848affe0786c798aea9e1a43dde54bc Modified Files -------------- src/backend/utils/init/postinit.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-11-11 22:06 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 22:06 pgsql: Parallel workers use AuthenticatedUserId for connection privileg Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox