pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Make the memory layout of Port struct independent of USE_OPENSSL 2+ messages / 1 participants [nested] [flat]
* pgsql: Make the memory layout of Port struct independent of USE_OPENSSL @ 2024-11-22 16:05 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-11-22 16:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make the memory layout of Port struct independent of USE_OPENSSL Commit d39a49c1e4 added new fields to the struct, but missed the "keep these last" comment on the previous fields. Add placeholder variables so that the offsets of the fields are the same whether you build with USE_OPENSSL or not. This is a courtesy to extensions that might peek at the fields, to make the ABI the same regardless of the options used to build PostgreSQL. In reality, I don't expect any extensions to look at the 'raw_buf' fields. Firstly, they are new in v17, so no one's written such extensions yet. Secondly, extensions should have no business poking at those fields anyway. Nevertheless, fix this properly on 'master'. On v17, we mustn't change the memory layout, so just fix the comments. Author: Jacob Champion Discussion: https://www.postgresql.org/message-id/raw/CAOYmi%2BmKVJNzn5_TD_MK%3DhqO64r_w8Gb0FHCLk0oAkW-PJv8jQ@ma... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8fb5936703e84945766b8425bfe54e0060dea231 Modified Files -------------- src/include/libpq/libpq-be.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Make the memory layout of Port struct independent of USE_OPENSSL @ 2024-11-22 16:05 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 2+ messages in thread From: Heikki Linnakangas @ 2024-11-22 16:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make the memory layout of Port struct independent of USE_OPENSSL Commit d39a49c1e4 added new fields to the struct, but missed the "keep these last" comment on the previous fields. Add placeholder variables so that the offsets of the fields are the same whether you build with USE_OPENSSL or not. This is a courtesy to extensions that might peek at the fields, to make the ABI the same regardless of the options used to build PostgreSQL. In reality, I don't expect any extensions to look at the 'raw_buf' fields. Firstly, they are new in v17, so no one's written such extensions yet. Secondly, extensions should have no business poking at those fields anyway. Nevertheless, fix this properly on 'master'. On v17, we mustn't change the memory layout, so just fix the comments. Author: Jacob Champion Discussion: https://www.postgresql.org/message-id/raw/CAOYmi%2BmKVJNzn5_TD_MK%3DhqO64r_w8Gb0FHCLk0oAkW-PJv8jQ@ma... Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e3b249c6d8f33227a5ee58f9b2d187e7ce71b4c7 Modified Files -------------- src/include/libpq/libpq-be.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-11-22 16:05 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-22 16:05 pgsql: Make the memory layout of Port struct independent of USE_OPENSSL Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-11-22 16:05 pgsql: Make the memory layout of Port struct independent of USE_OPENSSL Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox