pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix pg_get_constraintdef for NOT NULL constraints on domains 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix pg_get_constraintdef for NOT NULL constraints on domains @ 2024-11-27 12:51 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2024-11-27 12:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_get_constraintdef for NOT NULL constraints on domains We added pg_constraint rows for all not-null constraints, first for tables and later for domains; but while the ones for tables were reverted, the ones for domains were not. However, we did accidentally revert ruleutils.c support for the ones on domains in 6f8bb7c1e961, which breaks running pg_get_constraintdef() on them. Put that back. This is only needed in branch 17, because we've reinstated this code in branch master with commit 14e87ffa5c54. Add some new tests in both branches. I couldn't find anything else that needs de-reverting. Reported-by: Erki Eessaar <erki.eessaar@taltech.ee> Reviewed-by: Magnus Hagander <magnus@hagander.net> Discussion: https://postgr.es/m/AS8PR01MB75110350415AAB8BBABBA1ECFE222@AS8PR01MB7511.eurprd01.prod.exchangelabs.... Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6e793582bc663fb7652834170be8902b982b7bcb Modified Files -------------- src/backend/utils/adt/ruleutils.c | 5 +++++ src/test/regress/expected/domain.out | 14 ++++++++++++++ src/test/regress/sql/domain.sql | 11 +++++++++++ 3 files changed, 30 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix pg_get_constraintdef for NOT NULL constraints on domains @ 2024-11-27 12:51 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2024-11-27 12:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pg_get_constraintdef for NOT NULL constraints on domains We added pg_constraint rows for all not-null constraints, first for tables and later for domains; but while the ones for tables were reverted, the ones for domains were not. However, we did accidentally revert ruleutils.c support for the ones on domains in 6f8bb7c1e961, which breaks running pg_get_constraintdef() on them. Put that back. This is only needed in branch 17, because we've reinstated this code in branch master with commit 14e87ffa5c54. Add some new tests in both branches. I couldn't find anything else that needs de-reverting. Reported-by: Erki Eessaar <erki.eessaar@taltech.ee> Reviewed-by: Magnus Hagander <magnus@hagander.net> Discussion: https://postgr.es/m/AS8PR01MB75110350415AAB8BBABBA1ECFE222@AS8PR01MB7511.eurprd01.prod.exchangelabs.... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/09d09d4297b9acbc2848ec35e8bf030d6c1fae18 Modified Files -------------- src/test/regress/expected/domain.out | 14 ++++++++++++++ src/test/regress/sql/domain.sql | 11 +++++++++++ 2 files changed, 25 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-11-27 12:51 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-27 12:51 pgsql: Fix pg_get_constraintdef for NOT NULL constraints on domains Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-27 12:51 pgsql: Fix pg_get_constraintdef for NOT NULL constraints on domains Álvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox