pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: ci: Fix cached MacPorts installation management 4+ messages / 1 participants [nested] [flat]
* pgsql: ci: Fix cached MacPorts installation management @ 2024-11-27 16:52 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2024-11-27 16:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Fix cached MacPorts installation management 1. The error reporting of "port setrequested list-of-packages..." changed, hiding errors we were relying on to know if all packages in our list were already installed. Use a loop instead. 2. The cached MacPorts installation was shared between PostgreSQL major branches, though each branch wanted different packages. Add the list of packages to cache key, so that different branches, when tested in one github account/repo such as postgres/postgres, stop fighting with each other, adding and removing packages. Back-patch to 15 where CI began. Author: Thomas Munro <thomas.munro@gmail.com> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Suggested-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/au2uqfuy2nf43nwy2txmc5t2emhwij7kzupygto3d2ffgtrdgr%40ckvrlwyflnh2 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c26831e7362487b4f2c606e1223207baa1d495cb Modified Files -------------- .cirrus.tasks.yml | 34 ++++++++++++++++++---------------- src/tools/ci/ci_macports_packages.sh | 15 +++++++++++---- 2 files changed, 29 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: Fix cached MacPorts installation management @ 2024-11-27 16:52 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2024-11-27 16:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Fix cached MacPorts installation management 1. The error reporting of "port setrequested list-of-packages..." changed, hiding errors we were relying on to know if all packages in our list were already installed. Use a loop instead. 2. The cached MacPorts installation was shared between PostgreSQL major branches, though each branch wanted different packages. Add the list of packages to cache key, so that different branches, when tested in one github account/repo such as postgres/postgres, stop fighting with each other, adding and removing packages. Back-patch to 15 where CI began. Author: Thomas Munro <thomas.munro@gmail.com> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Suggested-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/au2uqfuy2nf43nwy2txmc5t2emhwij7kzupygto3d2ffgtrdgr%40ckvrlwyflnh2 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3bbfa2ef785a36c6aa48d9a7780274dcbc6d63fd Modified Files -------------- .cirrus.tasks.yml | 34 ++++++++++++++++++---------------- src/tools/ci/ci_macports_packages.sh | 15 +++++++++++---- 2 files changed, 29 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: Fix cached MacPorts installation management @ 2024-11-27 16:52 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2024-11-27 16:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Fix cached MacPorts installation management 1. The error reporting of "port setrequested list-of-packages..." changed, hiding errors we were relying on to know if all packages in our list were already installed. Use a loop instead. 2. The cached MacPorts installation was shared between PostgreSQL major branches, though each branch wanted different packages. Add the list of packages to cache key, so that different branches, when tested in one github account/repo such as postgres/postgres, stop fighting with each other, adding and removing packages. Back-patch to 15 where CI began. Author: Thomas Munro <thomas.munro@gmail.com> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Suggested-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/au2uqfuy2nf43nwy2txmc5t2emhwij7kzupygto3d2ffgtrdgr%40ckvrlwyflnh2 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/262283d5eec3d582a8645692fede2e8f5e6029bd Modified Files -------------- .cirrus.tasks.yml | 34 ++++++++++++++++++---------------- src/tools/ci/ci_macports_packages.sh | 15 +++++++++++---- 2 files changed, 29 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: Fix cached MacPorts installation management @ 2024-11-27 16:52 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2024-11-27 16:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Fix cached MacPorts installation management 1. The error reporting of "port setrequested list-of-packages..." changed, hiding errors we were relying on to know if all packages in our list were already installed. Use a loop instead. 2. The cached MacPorts installation was shared between PostgreSQL major branches, though each branch wanted different packages. Add the list of packages to cache key, so that different branches, when tested in one github account/repo such as postgres/postgres, stop fighting with each other, adding and removing packages. Back-patch to 15 where CI began. Author: Thomas Munro <thomas.munro@gmail.com> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Suggested-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/au2uqfuy2nf43nwy2txmc5t2emhwij7kzupygto3d2ffgtrdgr%40ckvrlwyflnh2 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c93dffd89ba58b1b22faae2d2a9ec95e536c6740 Modified Files -------------- .cirrus.tasks.yml | 34 ++++++++++++++++++---------------- src/tools/ci/ci_macports_packages.sh | 15 +++++++++++---- 2 files changed, 29 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-27 16:52 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-27 16:52 pgsql: ci: Fix cached MacPorts installation management Andres Freund <andres@anarazel.de> 2024-11-27 16:52 pgsql: ci: Fix cached MacPorts installation management Andres Freund <andres@anarazel.de> 2024-11-27 16:52 pgsql: ci: Fix cached MacPorts installation management Andres Freund <andres@anarazel.de> 2024-11-27 16:52 pgsql: ci: Fix cached MacPorts installation management Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox