pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix synchronized_standby_slots GUC check hook 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix synchronized_standby_slots GUC check hook @ 2024-12-03 16:51 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2024-12-03 16:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix synchronized_standby_slots GUC check hook The validate_sync_standby_slots subroutine requires an LWLock, so it cannot run in processes without PGPROC; skip it there to avoid a crash. This replaces the current test for ReplicationSlotCtl being not null, which appears to be a solution for the same problem but less general. I also rewrote a related comment that mentioned ReplicationSlotCtl in StandbySlotsHaveCaughtup. This code came in with commit bf279ddd1c28; backpatch to 17. Reported-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com> Discussion: https://postgr.es/m/202411281216.sutbxtr6idnn@alvherre.pgsql Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9abdc1841e16ff4eaf2fa8e2e0472ee71a4a5a5c Modified Files -------------- src/backend/replication/slot.c | 44 ++++++++++++++++-------------------------- 1 file changed, 17 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix synchronized_standby_slots GUC check hook @ 2024-12-03 16:51 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2024-12-03 16:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix synchronized_standby_slots GUC check hook The validate_sync_standby_slots subroutine requires an LWLock, so it cannot run in processes without PGPROC; skip it there to avoid a crash. This replaces the current test for ReplicationSlotCtl being not null, which appears to be a solution for the same problem but less general. I also rewrote a related comment that mentioned ReplicationSlotCtl in StandbySlotsHaveCaughtup. This code came in with commit bf279ddd1c28; backpatch to 17. Reported-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com> Discussion: https://postgr.es/m/202411281216.sutbxtr6idnn@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3c5f9f12c807760f6d512957a863113b07a79dcb Modified Files -------------- src/backend/replication/slot.c | 44 ++++++++++++++++-------------------------- 1 file changed, 17 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-12-03 16:51 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-12-03 16:51 pgsql: Fix synchronized_standby_slots GUC check hook Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-12-03 16:51 pgsql: Fix synchronized_standby_slots GUC check hook Álvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox