pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve reporting of pg_upgrade log files on test failure 4+ messages / 1 participants [nested] [flat]
* pgsql: Improve reporting of pg_upgrade log files on test failure @ 2024-12-10 23:49 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-12-10 23:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve reporting of pg_upgrade log files on test failure On failure, the pg_upgrade log files are automatically appended to the test log file, but the information reported was inconsistent. A header, with the log file name, was reported with note(), while the log contents and a footer used print(), making it harder to diagnose failures when these are split into console output and test log file because the pg_upgrade log file path in the header may not be included in the test log file. The output is now consolidated so as the header uses print() rather than note(). An extra note() is added to inform that the contents of a pg_upgrade log file are appended to the test log file. The diffs from the regression test suite and dump files all use print() to show their contents on failure. Author: Joel Jacobson Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a7740405e@app.fastmail.com Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8afff7d6db25ab52f155d8a220f692d7d6d84152 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve reporting of pg_upgrade log files on test failure @ 2024-12-10 23:49 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-12-10 23:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve reporting of pg_upgrade log files on test failure On failure, the pg_upgrade log files are automatically appended to the test log file, but the information reported was inconsistent. A header, with the log file name, was reported with note(), while the log contents and a footer used print(), making it harder to diagnose failures when these are split into console output and test log file because the pg_upgrade log file path in the header may not be included in the test log file. The output is now consolidated so as the header uses print() rather than note(). An extra note() is added to inform that the contents of a pg_upgrade log file are appended to the test log file. The diffs from the regression test suite and dump files all use print() to show their contents on failure. Author: Joel Jacobson Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a7740405e@app.fastmail.com Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/058b208a5d129dbc1d857338ad68b1fd6613d0e2 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve reporting of pg_upgrade log files on test failure @ 2024-12-10 23:49 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-12-10 23:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve reporting of pg_upgrade log files on test failure On failure, the pg_upgrade log files are automatically appended to the test log file, but the information reported was inconsistent. A header, with the log file name, was reported with note(), while the log contents and a footer used print(), making it harder to diagnose failures when these are split into console output and test log file because the pg_upgrade log file path in the header may not be included in the test log file. The output is now consolidated so as the header uses print() rather than note(). An extra note() is added to inform that the contents of a pg_upgrade log file are appended to the test log file. The diffs from the regression test suite and dump files all use print() to show their contents on failure. Author: Joel Jacobson Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a7740405e@app.fastmail.com Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8a8f26dda2255c64b991ce23ae0b2f612fc2b9d4 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Improve reporting of pg_upgrade log files on test failure @ 2024-12-10 23:49 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2024-12-10 23:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve reporting of pg_upgrade log files on test failure On failure, the pg_upgrade log files are automatically appended to the test log file, but the information reported was inconsistent. A header, with the log file name, was reported with note(), while the log contents and a footer used print(), making it harder to diagnose failures when these are split into console output and test log file because the pg_upgrade log file path in the header may not be included in the test log file. The output is now consolidated so as the header uses print() rather than note(). An extra note() is added to inform that the contents of a pg_upgrade log file are appended to the test log file. The diffs from the regression test suite and dump files all use print() to show their contents on failure. Author: Joel Jacobson Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/49f7e64a-b9be-4a90-a9fe-210a7740405e@app.fastmail.com Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8ede5016859e151003fdb662e13d11e43f372174 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-12-10 23:49 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-12-10 23:49 pgsql: Improve reporting of pg_upgrade log files on test failure Michael Paquier <michael@paquier.xyz> 2024-12-10 23:49 pgsql: Improve reporting of pg_upgrade log files on test failure Michael Paquier <michael@paquier.xyz> 2024-12-10 23:49 pgsql: Improve reporting of pg_upgrade log files on test failure Michael Paquier <michael@paquier.xyz> 2024-12-10 23:49 pgsql: Improve reporting of pg_upgrade log files on test failure Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox