pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup 2+ messages / 1 participants [nested] [flat]
* pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup @ 2024-12-17 00:25 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-12-17 00:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_combinebackup: Fix PITR comparison test in 002_compare_backups The test was creating both the dumps to compare from the same database on the same node, so it would never detect any mismatches when comparing the logical dumps of the two servers. Fixing this issue has revealed that there is a difference in the dumps: the tablespaces paths are different. This commit uses compare_text() with a custom comparison function to erase the difference (slightly tweaked to be able to work with WIN32 and non-WIN32 paths). This way, the non-relevant parts of the tablespace path are ignored from the check with the basic structure of the query string still compared. Author: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/87h67653ns.fsf@wibble.ilmari.org Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e116b703f0b9b551cb413c8f2cfe231a9ce73f42 Modified Files -------------- src/bin/pg_combinebackup/t/002_compare_backups.pl | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup @ 2024-12-17 00:25 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2024-12-17 00:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_combinebackup: Fix PITR comparison test in 002_compare_backups The test was creating both the dumps to compare from the same database on the same node, so it would never detect any mismatches when comparing the logical dumps of the two servers. Fixing this issue has revealed that there is a difference in the dumps: the tablespaces paths are different. This commit uses compare_text() with a custom comparison function to erase the difference (slightly tweaked to be able to work with WIN32 and non-WIN32 paths). This way, the non-relevant parts of the tablespace path are ignored from the check with the basic structure of the query string still compared. Author: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/87h67653ns.fsf@wibble.ilmari.org Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/94e7e77a95ba501955788e1e124b577a665cd85d Modified Files -------------- src/bin/pg_combinebackup/t/002_compare_backups.pl | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-12-17 00:25 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-12-17 00:25 pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup Michael Paquier <michael@paquier.xyz> 2024-12-17 00:25 pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox