pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull 6+ messages / 1 participants [nested] [flat]
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7819a25cd101b574f5422edb00fe3376fbb646da Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3637905c3cdfea95feda901ce570a077964c8d94 Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3d57f7cf300540bea6939fe5bdd820a606aa2669 Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/216294ba592fdfaa38bdf9767527f8424bd29b14 Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7b3259bd7cf37da472ff5c2ce25fe0aa552e6fe0 Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull @ 2025-01-25 19:29 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2025-01-25 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input. Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these Informix-compat functions return 0 without changing the output parameter. Initialize the output parameter before the test call, making that obvious. Before this, the expected test output has been depending on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed that. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6c1cc35d90c74f45e4ca493cddf418629ceb77dc Modified Files -------------- .../ecpg/test/compat_informix/dec_test.pgc | 10 + .../ecpg/test/expected/compat_informix-dec_test.c | 10 + .../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++----------- 3 files changed, 136 insertions(+), 116 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-01-25 19:29 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com> 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com> 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com> 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com> 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com> 2025-01-25 19:29 pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox