pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). 6+ messages / 1 participants [nested] [flat]
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f3e4aeb744da6acf909e9c5a7a83338fba1984a7 Modified Files -------------- src/bin/scripts/vacuumdb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8703cdec2055d055583ca17ef2d2b5052b064a15 Modified Files -------------- src/bin/scripts/vacuumdb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e8d8174caf75c5724847b43b886a7feb1628c4d4 Modified Files -------------- src/bin/scripts/vacuumdb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8c2dd212d1bcefa8d2cbcbe53398de367c2d5f63 Modified Files -------------- src/bin/scripts/vacuumdb.c | 9 +++++++++ 1 file changed, 9 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/eeaf6891be48ac2940361717525c277a02c97e63 Modified Files -------------- src/bin/scripts/vacuumdb.c | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). @ 2025-02-04 19:28 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-02-04 19:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). A few of the version checks in vacuum_one_database() do not call PQfinish() before exiting. This precedent was unintentionally established in commit 00d1e88d36, and while it's probably not too problematic, it seems better to properly close the connection. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/Z6JAwqN1I8ljTuXp%40nathan Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d6ea82f5da181eb4278595d7dca601568deeed5e Modified Files -------------- src/bin/scripts/vacuumdb.c | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-02-04 19:28 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org> 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org> 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org> 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org> 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org> 2025-02-04 19:28 pgsql: vacuumdb: Add missing PQfinish() calls to vacuum_one_database(). Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox