pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Specify the encoding of input to fmtId() 6+ messages / 1 participants [nested] [flat]
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3e98c8ce50e46d58b91bf3ea806e995296dc5b91 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 16 ++++--- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 115 insertions(+), 24 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/56aa2dcddeb299f62dad98ba50ad8db47cddaf97 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 11 +++-- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 112 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/61ad93cdd48ecc8c6edf943f4d888a9325b66882 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 16 ++++--- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 115 insertions(+), 24 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5df4e1632e65323ad9b33d7dfe721117a6060fbe Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 8 ++-- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 110 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2ae54ae17eaad592991e7459140b2cad2e82745c Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 11 +++-- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 112 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Specify the encoding of input to fmtId() @ 2025-02-10 15:09 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 6+ messages in thread From: Andres Freund @ 2025-02-10 15:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Specify the encoding of input to fmtId() This commit adds fmtIdEnc() and fmtQualifiedIdEnc(), which allow to specify the encoding as an explicit argument. Additionally setFmtEncoding() is provided, which defines the encoding when no explicit encoding is provided, to avoid breaking all code using fmtId(). All users of fmtId()/fmtQualifiedId() are either converted to the explicit version or a call to setFmtEncoding() has been added. This commit does not yet utilize the now well-defined encoding, that will happen in a subsequent commit. Reviewed-by: Noah Misch <noah@leadboat.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 13 Security: CVE-2025-1094 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b1756da7541323eae07fe23eaad17ce12f20a56b Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 1 + src/bin/pg_dump/pg_dump.c | 1 + src/bin/pg_dump/pg_dumpall.c | 1 + src/bin/psql/command.c | 3 ++ src/bin/scripts/common.c | 5 ++- src/bin/scripts/createdb.c | 2 + src/bin/scripts/createuser.c | 2 + src/bin/scripts/dropdb.c | 13 +++--- src/bin/scripts/dropuser.c | 3 +- src/bin/scripts/reindexdb.c | 11 +++-- src/bin/scripts/vacuumdb.c | 5 ++- src/fe_utils/string_utils.c | 84 +++++++++++++++++++++++++++++++++--- src/include/fe_utils/string_utils.h | 3 ++ 13 files changed, 112 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-02-10 15:09 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de> 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de> 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de> 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de> 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de> 2025-02-10 15:09 pgsql: Specify the encoding of input to fmtId() Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox