pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect 6+ messages / 1 participants [nested] [flat]
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5bf12323b6b8b05790aab6876555568898f4fc81 Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/85c1fcc6563843d7ee7ae6f81f29ef813e77a4b6 Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0075a5c6ce5bb6f3ee005a54cd5b518f16659655 Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9862de9176ef161e20a40f327afe18c6a11ecdcc Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e1f1b030d7d9fea27a77a335699372e0b222c61a Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect @ 2025-02-10 21:31 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2025-02-10 21:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations. We need to tell fmtId() what encoding to assume, but this function doesn't know that. Fortunately we can fix that without changing the function's API, because we can just use SQL_ASCII. That's because database names in connection requests are effectively binary not text: no encoding-aware processing will happen on them. This fixes XversionUpgrade failures seen in the buildfarm. The alternative of having pg_upgrade use setFmtEncoding() is unappetizing, given that it's connecting to multiple databases that may have different encodings. Andres Freund, Noah Misch, Tom Lane Security: CVE-2025-1094 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f9fceef6ee020717ffbd18cfaa0b77e583348734 Modified Files -------------- src/fe_utils/string_utils.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-02-10 21:31 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us> 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us> 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us> 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us> 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us> 2025-02-10 21:31 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox