pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix issue in recovery test 041_checkpoint_at_promote 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix issue in recovery test 041_checkpoint_at_promote @ 2025-02-12 08:58 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-02-12 08:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue in recovery test 041_checkpoint_at_promote The phase of the test waiting for a restartpoint to complete was not working as intended, due to a log_contains() call incorrectly written. The problem reported by the author could be simply reproduced by removing the injection_points_wakeup() call: the test succeeds rather than waiting for the restartpoint completion. In most cases, the restartpoint completion is fast enough that the test offered the wanted coverage. On slow machines, it could have become unreliable. Oversight in 6782709df81f. Author: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0fc68c8421b656f2ad03e788d97ff0c59da60e6f Modified Files -------------- src/test/recovery/t/041_checkpoint_at_promote.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix issue in recovery test 041_checkpoint_at_promote @ 2025-02-12 08:58 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-02-12 08:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue in recovery test 041_checkpoint_at_promote The phase of the test waiting for a restartpoint to complete was not working as intended, due to a log_contains() call incorrectly written. The problem reported by the author could be simply reproduced by removing the injection_points_wakeup() call: the test succeeds rather than waiting for the restartpoint completion. In most cases, the restartpoint completion is fast enough that the test offered the wanted coverage. On slow machines, it could have become unreliable. Oversight in 6782709df81f. Author: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3dea7af519fd2b6e098c4261cb91d318cf31a8d4 Modified Files -------------- src/test/recovery/t/041_checkpoint_at_promote.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-02-12 08:58 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-12 08:58 pgsql: Fix issue in recovery test 041_checkpoint_at_promote Michael Paquier <michael@paquier.xyz> 2025-02-12 08:58 pgsql: Fix issue in recovery test 041_checkpoint_at_promote Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox