pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Make test portlock logic work with meson 3+ messages / 1 participants [nested] [flat]
* pgsql: Make test portlock logic work with meson @ 2025-02-21 16:48 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2025-02-21 16:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make test portlock logic work with meson Previously the portlock logic, added in 9b4eafcaf41, didn't actually work properly when the tests were run via meson. 9b4eafcaf41 used the MESON_BUILD_ROOT environment variable to determine the directory for the port lock directory, but that's never set for running the tests. That meant that each test used its own portlock dir, unless the PG_TEST_PORT_DIR environment variable was set. Fix the problem by setting top_builddir for the environment. That's also used for the autoconf/make build. Backpatch back to 16, where meson support was added. Reported-by: Zharkov Roman <r.zharkov@postgrespro.ru> Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/32ce58e9e97723958d43e09fc3203a302c1eb4b5 Modified Files -------------- meson.build | 2 ++ src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Make test portlock logic work with meson @ 2025-02-21 16:48 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2025-02-21 16:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make test portlock logic work with meson Previously the portlock logic, added in 9b4eafcaf41, didn't actually work properly when the tests were run via meson. 9b4eafcaf41 used the MESON_BUILD_ROOT environment variable to determine the directory for the port lock directory, but that's never set for running the tests. That meant that each test used its own portlock dir, unless the PG_TEST_PORT_DIR environment variable was set. Fix the problem by setting top_builddir for the environment. That's also used for the autoconf/make build. Backpatch back to 16, where meson support was added. Reported-by: Zharkov Roman <r.zharkov@postgrespro.ru> Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0f7c0fb59cb71e1ecd45c6892ab184fefbfde8be Modified Files -------------- meson.build | 2 ++ src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Make test portlock logic work with meson @ 2025-02-21 16:48 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2025-02-21 16:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make test portlock logic work with meson Previously the portlock logic, added in 9b4eafcaf41, didn't actually work properly when the tests were run via meson. 9b4eafcaf41 used the MESON_BUILD_ROOT environment variable to determine the directory for the port lock directory, but that's never set for running the tests. That meant that each test used its own portlock dir, unless the PG_TEST_PORT_DIR environment variable was set. Fix the problem by setting top_builddir for the environment. That's also used for the autoconf/make build. Backpatch back to 16, where meson support was added. Reported-by: Zharkov Roman <r.zharkov@postgrespro.ru> Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28fcaa6a2cc0d261ae23d56507ca52f928e54340 Modified Files -------------- meson.build | 2 ++ src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-02-21 16:48 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-21 16:48 pgsql: Make test portlock logic work with meson Andres Freund <andres@anarazel.de> 2025-02-21 16:48 pgsql: Make test portlock logic work with meson Andres Freund <andres@anarazel.de> 2025-02-21 16:48 pgsql: Make test portlock logic work with meson Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox