pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Silence warning in older versions of Valgrind 2+ messages / 1 participants [nested] [flat]
* pgsql: Silence warning in older versions of Valgrind @ 2025-02-24 11:06 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: John Naylor @ 2025-02-24 11:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence warning in older versions of Valgrind Due to misunderstanding on my part, commit 235328ee4 did not go far enough to silence older versions of Valgrind. For those, it was the bit scan that was problematic, not the subsequent bit-masking operation. To fix, use the unaligned path for the trailing bytes. Since we don't have a bit scan here anymore, also remove some comments and endian-specific coding around that. Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru> Discussion: https://postgr.es/m/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0600d276d485a8222eb6b571b08889c9f539e86f Modified Files -------------- src/include/common/hashfn_unstable.h | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Silence warning in older versions of Valgrind @ 2025-02-24 11:07 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: John Naylor @ 2025-02-24 11:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence warning in older versions of Valgrind Due to misunderstanding on my part, commit 235328ee4 did not go far enough to silence older versions of Valgrind. For those, it was the bit scan that was problematic, not the subsequent bit-masking operation. To fix, use the unaligned path for the trailing bytes. Since we don't have a bit scan here anymore, also remove some comments and endian-specific coding around that. Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru> Discussion: https://postgr.es/m/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fde7c0164ea20433964a0a05a91c5708384a285c Modified Files -------------- src/include/common/hashfn_unstable.h | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-02-24 11:07 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-24 11:06 pgsql: Silence warning in older versions of Valgrind John Naylor <john.naylor@postgresql.org> 2025-02-24 11:07 pgsql: Silence warning in older versions of Valgrind John Naylor <john.naylor@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox