public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: Set amcancrosscompare to true for hash
4+ messages / 4 participants
[nested] [flat]

* pgsql: Set amcancrosscompare to true for hash
@ 2025-03-01 08:23 Peter Eisentraut <[email protected]>
  2025-03-03 16:44 ` Re: pgsql: Set amcancrosscompare to true for hash Melanie Plageman <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Peter Eisentraut @ 2025-03-01 08:23 UTC (permalink / raw)
  To: [email protected]

Set amcancrosscompare to true for hash

This was missed in the refactoring in patch ce62f2f2a0a, which thus
created a regression.

Reported-by: Tom Lane <[email protected]>
Reviewed-by: Mark Dilger <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/E1tngY6-0000UL-2n%40gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/56ba0463d38c17400a090353db47cf455ce01c3d

Modified Files
--------------
src/backend/access/hash/hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Set amcancrosscompare to true for hash
  2025-03-01 08:23 pgsql: Set amcancrosscompare to true for hash Peter Eisentraut <[email protected]>
@ 2025-03-03 16:44 ` Melanie Plageman <[email protected]>
  2025-03-03 17:48   ` Re: pgsql: Set amcancrosscompare to true for hash Tom Lane <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Melanie Plageman @ 2025-03-03 16:44 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: [email protected]

Is there a discussion somewhere about why valgrind has been failing
like this on skink since Saturday?

valgrind:  Fatal error at startup: a function redirection
valgrind:  which is mandatory for this platform-tool combination
valgrind:  cannot be set up.  Details of the redirection are:

It doesn't seem it could be caused by this commit, but this is the
first commit it is failing on and I don't usually see much discussion
in reply to the failures on pgsql-buildfarm.

- Melanie





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Set amcancrosscompare to true for hash
  2025-03-01 08:23 pgsql: Set amcancrosscompare to true for hash Peter Eisentraut <[email protected]>
  2025-03-03 16:44 ` Re: pgsql: Set amcancrosscompare to true for hash Melanie Plageman <[email protected]>
@ 2025-03-03 17:48   ` Tom Lane <[email protected]>
  2025-03-03 18:02     ` Re: pgsql: Set amcancrosscompare to true for hash Andres Freund <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Tom Lane @ 2025-03-03 17:48 UTC (permalink / raw)
  To: Melanie Plageman <[email protected]>; +Cc: Andres Freund <[email protected]>; [email protected]

Melanie Plageman <[email protected]> writes:
> Is there a discussion somewhere about why valgrind has been failing
> like this on skink since Saturday?

> valgrind:  Fatal error at startup: a function redirection
> valgrind:  which is mandatory for this platform-tool combination
> valgrind:  cannot be set up.  Details of the redirection are:

Looks to me like a broken software update on the host ...

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Set amcancrosscompare to true for hash
  2025-03-01 08:23 pgsql: Set amcancrosscompare to true for hash Peter Eisentraut <[email protected]>
  2025-03-03 16:44 ` Re: pgsql: Set amcancrosscompare to true for hash Melanie Plageman <[email protected]>
  2025-03-03 17:48   ` Re: pgsql: Set amcancrosscompare to true for hash Tom Lane <[email protected]>
@ 2025-03-03 18:02     ` Andres Freund <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Andres Freund @ 2025-03-03 18:02 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Melanie Plageman <[email protected]>; [email protected]

Hi,

On 2025-03-03 12:48:27 -0500, Tom Lane wrote:
> Melanie Plageman <[email protected]> writes:
> > Is there a discussion somewhere about why valgrind has been failing
> > like this on skink since Saturday?
> 
> > valgrind:  Fatal error at startup: a function redirection
> > valgrind:  which is mandatory for this platform-tool combination
> > valgrind:  cannot be set up.  Details of the redirection are:
> 
> Looks to me like a broken software update on the host ...

Yes. I think I fixed it a bit ago, the current run is running for longer than
the last few runs.

Hm, independent of that concrete breakage it looks like skink is running far
fewer things under valgrind than it used to. Looks like it's related to a
buildfarm client upgrade... The next run after this one will probably take a
good bit longer.

Greetings,

Andres Freund






^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2025-03-03 18:02 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-01 08:23 pgsql: Set amcancrosscompare to true for hash Peter Eisentraut <[email protected]>
2025-03-03 16:44 ` Melanie Plageman <[email protected]>
2025-03-03 17:48   ` Tom Lane <[email protected]>
2025-03-03 18:02     ` Andres Freund <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox