public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: [email protected]
Subject: pgsql: Remove now-dead code in StoreAttrDefault().
Date: Mon, 03 Mar 2025 18:35:58 +0000
Message-ID: <[email protected]> (raw)
Remove now-dead code in StoreAttrDefault().
StoreAttrDefault() is no longer responsible for filling
attmissingval, so remove the code for that.
Get rid of RawColumnDefault.missingMode, too, as we no longer
need that to pass information around.
While here, clean up some sloppy coding in StoreAttrDefault(),
such as failure to use XXXGetDatum macros. These aren't bugs
but they're not good code either.
Reported-by: jian he <[email protected]>
Author: jian he <[email protected]>
Author: Tom Lane <[email protected]>
Discussion: https://postgr.es/m/CACJufxHFssPvkP1we7WMhPD_1kwgbG52o=kQgL+TnVoX5LOyCQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4528768d98f83070d625207dcb526982fb18f1ce
Modified Files
--------------
src/backend/catalog/heap.c | 5 ++-
src/backend/catalog/pg_attrdef.c | 77 ++++------------------------------------
src/backend/commands/tablecmds.c | 8 ++---
src/include/catalog/heap.h | 1 -
src/include/catalog/pg_attrdef.h | 3 +-
5 files changed, 11 insertions(+), 83 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Remove now-dead code in StoreAttrDefault().
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox