public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: [email protected]
Subject: pgsql: Fix ALTER TABLE error message
Date: Tue, 04 Mar 2025 19:09:25 +0000
Message-ID: <[email protected]> (raw)

Fix ALTER TABLE error message

This bogus error message was introduced in 2013 by commit f177cbfe676d,
because of misunderstanding the processCASbits() API; at the time, no
test cases were added that would be affected by this change.  Only in
ca87c415e2fc was one added (along with a couple of typos), with an XXX
note that the error message was bogus.  Fix the whole, add some test
cases.

Backpatch all the way back.

Reviewed-by: Nathan Bossart <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7bbc46213de9301795da90923a015070239c1fcc

Modified Files
--------------
src/backend/parser/gram.y                 |  2 +-
src/test/regress/expected/constraints.out |  7 +++----
src/test/regress/expected/foreign_key.out | 10 +++++++++-
src/test/regress/sql/constraints.sql      |  3 +--
src/test/regress/sql/foreign_key.sql      |  4 +++-
5 files changed, 17 insertions(+), 9 deletions(-)

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Fix ALTER TABLE error message
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox