public inbox for [email protected]  

help / color / mirror / Atom feed
From: Masahiko Sawada <[email protected]>
To: [email protected]
Subject: pgsql: pg_upgrade: Check for the expected error message in TAP tests.
Date: Tue, 04 Mar 2025 19:16:30 +0000
Message-ID: <[email protected]> (raw)

pg_upgrade: Check for the expected error message in TAP tests.

Since pg_upgrade prints its error messages on stdout, we can't use
command_fails_like() to check if it fails for the right reason. This
commit uses command_checks_all() in pg_upgrade TAP tests to check the
exit status and stdout, enabling proper verification of error
reasons.

Author: Dagfinn Ilmari MannsÃ¥ker <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f52345995d3691de7b0a888903b6cfed1497c672

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl      | 5 ++++-
src/bin/pg_upgrade/t/004_subscription.pl    | 7 ++++++-
src/bin/pg_upgrade/t/005_char_signedness.pl | 5 ++++-
3 files changed, 14 insertions(+), 3 deletions(-)



reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: pg_upgrade: Check for the expected error message in TAP tests.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox