public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: [email protected]
Subject: pgsql: Remove count_one_bits() in acl.c.
Date: Wed, 12 Mar 2025 20:02:33 +0000
Message-ID: <[email protected]> (raw)
Remove count_one_bits() in acl.c.
The only caller, select_best_grantor(), can instead use
pg_popcount64(). This isn't performance-critical code, but we
might as well use the centralized implementation. While at it, add
some test coverage for this part of select_best_grantor().
Reviewed-by: Álvaro Herrera <[email protected]>
Discussion: https://postgr.es/m/Z9GtL7Nm6hsYyJnF%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/025e7e1eb4b884a187ade19f2ed479b256306a82
Modified Files
--------------
src/backend/utils/adt/acl.c | 20 +-------------------
src/test/regress/expected/privileges.out | 27 +++++++++++++++++++++++++++
src/test/regress/sql/privileges.sql | 22 ++++++++++++++++++++++
3 files changed, 50 insertions(+), 19 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Remove count_one_bits() in acl.c.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox