public inbox for [email protected]  
help / color / mirror / Atom feed
From: Heikki Linnakangas <[email protected]>
To: [email protected]
Subject: pgsql: Rename alloc/free functions in reorderbuffer.c
Date: Wed, 12 Mar 2025 20:04:13 +0000
Message-ID: <[email protected]> (raw)

Rename alloc/free functions in reorderbuffer.c

There used to be bespoken pools for these structs to reduce the
palloc/pfree overhead, but that was ripped out a long time ago and
replaced with the generic, cheaper generational memory allocator
(commit a4ccc1cef5). The Get/Return terminology made sense with the
pools, as you "got" an object from the pool and "returned" it later,
but now it just looks weird. Rename to Alloc/Free.

Reviewed-by: Tom Lane <[email protected]>
Discussion: https://www.postgresql.org/message-id/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac4494646daee27df20f7cded3ad49be24e9a98c

Modified Files
--------------
src/backend/replication/logical/decode.c        | 26 ++++----
src/backend/replication/logical/reorderbuffer.c | 89 ++++++++++++-------------
src/include/replication/reorderbuffer.h         | 15 ++---
3 files changed, 64 insertions(+), 66 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Rename alloc/free functions in reorderbuffer.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox