public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Fix read_stream.c for changing io_combine_limit.
2+ messages / 1 participants
[nested] [flat]
* pgsql: Fix read_stream.c for changing io_combine_limit.
@ 2025-03-13 03:00 Thomas Munro <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Munro @ 2025-03-13 03:00 UTC (permalink / raw)
To: [email protected]
Fix read_stream.c for changing io_combine_limit.
In a couple of places, read_stream.c assumed that io_combine_limit would
be stable during the lifetime of a stream. That is not true in at least
one unusual case: streams held by CURSORs where you could change the GUC
between FETCH commands, with unpredictable results.
Fix, by storing stream->io_combine_limit and referring only to that
after construction. This mirrors the treatment of the other important
setting {effective,maintenance}_io_concurrency, which is stored in
stream->max_ios.
One of the cases was the queue overflow space, which was sized for
io_combine_limit and could be overrun if the GUC was increased. Since
that coding was a little hard to follow, also introduce a variable for
better readability instead of open-coding the arithmetic. Doing so
revealed an off-by-one thinko while clamping max_pinned_buffers to
INT16_MAX, though that wasn't a live bug due to the current limits on
GUC values.
Back-patch to 17.
Discussion: https://postgr.es/m/CA%2BhUKG%2B2T9p-%2BzM6Eeou-RAJjTML6eit1qn26f9twznX59qtCA%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/75da2bece670059f3c1a3628dfbc3d24cc9638b8
Modified Files
--------------
src/backend/storage/aio/read_stream.c | 38 +++++++++++++++++++++++++----------
1 file changed, 27 insertions(+), 11 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix read_stream.c for changing io_combine_limit.
@ 2025-03-13 03:00 Thomas Munro <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Munro @ 2025-03-13 03:00 UTC (permalink / raw)
To: [email protected]
Fix read_stream.c for changing io_combine_limit.
In a couple of places, read_stream.c assumed that io_combine_limit would
be stable during the lifetime of a stream. That is not true in at least
one unusual case: streams held by CURSORs where you could change the GUC
between FETCH commands, with unpredictable results.
Fix, by storing stream->io_combine_limit and referring only to that
after construction. This mirrors the treatment of the other important
setting {effective,maintenance}_io_concurrency, which is stored in
stream->max_ios.
One of the cases was the queue overflow space, which was sized for
io_combine_limit and could be overrun if the GUC was increased. Since
that coding was a little hard to follow, also introduce a variable for
better readability instead of open-coding the arithmetic. Doing so
revealed an off-by-one thinko while clamping max_pinned_buffers to
INT16_MAX, though that wasn't a live bug due to the current limits on
GUC values.
Back-patch to 17.
Discussion: https://postgr.es/m/CA%2BhUKG%2B2T9p-%2BzM6Eeou-RAJjTML6eit1qn26f9twznX59qtCA%40mail.gmail.com
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e273468070ab4212b0babb5b6e94cb57256c3512
Modified Files
--------------
src/backend/storage/aio/read_stream.c | 38 +++++++++++++++++++++++++----------
1 file changed, 27 insertions(+), 11 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-03-13 03:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-13 03:00 pgsql: Fix read_stream.c for changing io_combine_limit. Thomas Munro <[email protected]>
2025-03-13 03:00 pgsql: Fix read_stream.c for changing io_combine_limit. Thomas Munro <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox