public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: [email protected]
Subject: pgsql: aio: Add io_method=worker
Date: Tue, 18 Mar 2025 16:01:44 +0000
Message-ID: <[email protected]> (raw)

aio: Add io_method=worker

The previous commit introduced the infrastructure to start io_workers. This
commit actually makes the workers execute IOs.

IO workers consume IOs from a shared memory submission queue, run traditional
synchronous system calls, and perform the shared completion handling
immediately.  Client code submits most requests by pushing IOs into the
submission queue, and waits (if necessary) using condition variables.  Some
IOs cannot be performed in another process due to lack of infrastructure for
reopening the file, and must processed synchronously by the client code when
submitted.

For now the default io_method is changed to "worker". We should re-evaluate
that around beta1, we might want to be careful and set the default to "sync"
for 18.

Reviewed-by: Noah Misch <[email protected]>
Co-authored-by: Thomas Munro <[email protected]>
Co-authored-by: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/uvrtrknj4kdytuboidbhwclo4gxhswwcpgadptsjvjqcluzmah%40brqs62irg4dt
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/stj36ea6yyhoxtqkhpieia2z4krnam7qyetc57rfezgk4zgapf@gcnactj4z56m

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/247ce06b883d7b3a40d08312dc03dfb37fbff212

Modified Files
--------------
doc/src/sgml/config.sgml                        |   5 +
src/backend/storage/aio/aio.c                   |   2 +
src/backend/storage/aio/aio_init.c              |   9 +
src/backend/storage/aio/method_worker.c         | 445 +++++++++++++++++++++++-
src/backend/utils/activity/wait_event_names.txt |   1 +
src/backend/utils/misc/postgresql.conf.sample   |   2 +-
src/include/storage/aio.h                       |   5 +-
src/include/storage/aio_internal.h              |   1 +
src/include/storage/lwlocklist.h                |   1 +
src/tools/pgindent/typedefs.list                |   3 +
10 files changed, 466 insertions(+), 8 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: aio: Add io_method=worker
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox