public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Fix guc_malloc calls for consistency and OOM checks 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix guc_malloc calls for consistency and OOM checks @ 2025-03-27 22:12 Daniel Gustafsson <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2025-03-27 22:12 UTC (permalink / raw) To: [email protected] Fix guc_malloc calls for consistency and OOM checks check_createrole_self_grant and check_synchronized_standby_slots were allocating memory on a LOG elevel without checking if the allocation succeeded or not, which would have led to a segfault on allocation failure. On top of that, a number of callsites were using the ERROR level, relying on erroring out rather than returning false to allow the GUC machinery handle it gracefully. Other callsites used WARNING instead of LOG. While neither being not wrong, this changes all check_ functions do it consistently with LOG. init_custom_variable gets a promoted elevel to FATAL to keep the guc_malloc error handling in line with the rest of the error handling in that function which already call FATAL. If we encounter an OOM in this callsite there is no graceful handling to be had, better to error out hard. Backpatch the fix to check_createrole_self_grant down to v16 and the fix to check_synchronized_standby_slots down to v17 where they were introduced. Author: Daniel Gustafsson <[email protected]> Reported-by: Nikita <[email protected]> Reviewed-by: Tom Lane <[email protected]> Bug: #18845 Discussion: https://postgr.es/m/[email protected] Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/058b5152f02ef86c98a795c14dbd6a8e195f4fd1 Modified Files -------------- src/backend/access/transam/xlog.c | 4 +++- src/backend/access/transam/xlogrecovery.c | 12 +++++++++--- src/backend/commands/user.c | 2 ++ src/backend/commands/variable.c | 4 ++-- src/backend/replication/slot.c | 2 ++ src/backend/storage/file/fd.c | 4 +++- src/backend/tcop/backend_startup.c | 4 +++- src/backend/tcop/postgres.c | 4 +++- src/backend/utils/error/elog.c | 8 ++++++-- src/backend/utils/misc/guc.c | 5 +++-- 10 files changed, 36 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix guc_malloc calls for consistency and OOM checks @ 2025-03-27 22:13 Daniel Gustafsson <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2025-03-27 22:13 UTC (permalink / raw) To: [email protected] Fix guc_malloc calls for consistency and OOM checks check_createrole_self_grant and check_synchronized_standby_slots were allocating memory on a LOG elevel without checking if the allocation succeeded or not, which would have led to a segfault on allocation failure. On top of that, a number of callsites were using the ERROR level, relying on erroring out rather than returning false to allow the GUC machinery handle it gracefully. Other callsites used WARNING instead of LOG. While neither being not wrong, this changes all check_ functions do it consistently with LOG. init_custom_variable gets a promoted elevel to FATAL to keep the guc_malloc error handling in line with the rest of the error handling in that function which already call FATAL. If we encounter an OOM in this callsite there is no graceful handling to be had, better to error out hard. Backpatch the fix to check_createrole_self_grant down to v16 and the fix to check_synchronized_standby_slots down to v17 where they were introduced. Author: Daniel Gustafsson <[email protected]> Reported-by: Nikita <[email protected]> Reviewed-by: Tom Lane <[email protected]> Bug: #18845 Discussion: https://postgr.es/m/[email protected] Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8afec4ef67a2fcec2ad0537fad5bc66e4388bc41 Modified Files -------------- src/backend/commands/user.c | 2 ++ src/backend/replication/slot.c | 2 ++ 2 files changed, 4 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix guc_malloc calls for consistency and OOM checks @ 2025-03-27 22:13 Daniel Gustafsson <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2025-03-27 22:13 UTC (permalink / raw) To: [email protected] Fix guc_malloc calls for consistency and OOM checks check_createrole_self_grant and check_synchronized_standby_slots were allocating memory on a LOG elevel without checking if the allocation succeeded or not, which would have led to a segfault on allocation failure. On top of that, a number of callsites were using the ERROR level, relying on erroring out rather than returning false to allow the GUC machinery handle it gracefully. Other callsites used WARNING instead of LOG. While neither being not wrong, this changes all check_ functions do it consistently with LOG. init_custom_variable gets a promoted elevel to FATAL to keep the guc_malloc error handling in line with the rest of the error handling in that function which already call FATAL. If we encounter an OOM in this callsite there is no graceful handling to be had, better to error out hard. Backpatch the fix to check_createrole_self_grant down to v16 and the fix to check_synchronized_standby_slots down to v17 where they were introduced. Author: Daniel Gustafsson <[email protected]> Reported-by: Nikita <[email protected]> Reviewed-by: Tom Lane <[email protected]> Bug: #18845 Discussion: https://postgr.es/m/[email protected] Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8d48e84c56889ea26ad1446ce9f22d12bfdb0c14 Modified Files -------------- src/backend/commands/user.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-03-27 22:13 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-03-27 22:12 pgsql: Fix guc_malloc calls for consistency and OOM checks Daniel Gustafsson <[email protected]> 2025-03-27 22:13 pgsql: Fix guc_malloc calls for consistency and OOM checks Daniel Gustafsson <[email protected]> 2025-03-27 22:13 pgsql: Fix guc_malloc calls for consistency and OOM checks Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox