public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: [email protected]
Subject: pgsql: Let caller of PageIsVerified() control ignore_checksum_failure
Date: Sun, 30 Mar 2025 20:28:43 +0000
Message-ID: <[email protected]> (raw)

Let caller of PageIsVerified() control ignore_checksum_failure

For AIO the completion of a read into shared buffers (i.e. verifying the page
including the checksum, updating the BufferDesc to reflect the IO) can happen
in a different backend than the backend that started the IO. As
ignore_checksum_failure can differ between backends, we need to allow the
caller of PageIsVerified() control whether to ignore checksum failures.

The commit leaves a gap in the PIV_* values, as an upcoming commit, which
depends on this commit, will add PIV_LOG_LOG, which better fits just after
PIV_LOG_WARNING.

Reviewed-by: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d445990adc419f435360f0dcd91c05c082f5fa3f

Modified Files
--------------
src/backend/catalog/storage.c       | 7 +++++--
src/backend/storage/buffer/bufmgr.c | 6 +++++-
src/backend/storage/page/bufpage.c  | 8 ++++++--
src/include/storage/bufpage.h       | 1 +
4 files changed, 17 insertions(+), 5 deletions(-)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Let caller of PageIsVerified() control ignore_checksum_failure
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox