public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO @ 2025-04-01 22:57 David Rowley <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: David Rowley @ 2025-04-01 22:57 UTC (permalink / raw) To: [email protected] Fix planner's failure to identify multiple hashable ScalarArrayOpExprs 50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify IN and NOT IN clauses which have Const lists as right-hand arguments and when an appropriate hash function is available for the data types, mark the ScalarArrayOpExpr as hashable so the executor could execute it more optimally by building and probing a hash table during expression evaluation. These commits both worked correctly when there was only a single ScalarArrayOpExpr in the given expression being processed by the planner, but when there were multiple, only the first was checked and any subsequent ones were not identified, which resulted in less optimal expression evaluation during query execution for all but the first found ScalarArrayOpExpr. Backpatch to 14, where 50e17ad28 was introduced. Author: David Geier <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b136db07c651e5048d44add0a01d5fc01b6fe0dc Modified Files -------------- src/backend/optimizer/util/clauses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO @ 2025-04-01 22:57 David Rowley <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: David Rowley @ 2025-04-01 22:57 UTC (permalink / raw) To: [email protected] Fix planner's failure to identify multiple hashable ScalarArrayOpExprs 50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify IN and NOT IN clauses which have Const lists as right-hand arguments and when an appropriate hash function is available for the data types, mark the ScalarArrayOpExpr as hashable so the executor could execute it more optimally by building and probing a hash table during expression evaluation. These commits both worked correctly when there was only a single ScalarArrayOpExpr in the given expression being processed by the planner, but when there were multiple, only the first was checked and any subsequent ones were not identified, which resulted in less optimal expression evaluation during query execution for all but the first found ScalarArrayOpExpr. Backpatch to 14, where 50e17ad28 was introduced. Author: David Geier <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5672a839977949457d1f81a4fd43b1e7c097ba14 Modified Files -------------- src/backend/optimizer/util/clauses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO @ 2025-04-01 22:58 David Rowley <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: David Rowley @ 2025-04-01 22:58 UTC (permalink / raw) To: [email protected] Fix planner's failure to identify multiple hashable ScalarArrayOpExprs 50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify IN and NOT IN clauses which have Const lists as right-hand arguments and when an appropriate hash function is available for the data types, mark the ScalarArrayOpExpr as hashable so the executor could execute it more optimally by building and probing a hash table during expression evaluation. These commits both worked correctly when there was only a single ScalarArrayOpExpr in the given expression being processed by the planner, but when there were multiple, only the first was checked and any subsequent ones were not identified, which resulted in less optimal expression evaluation during query execution for all but the first found ScalarArrayOpExpr. Backpatch to 14, where 50e17ad28 was introduced. Author: David Geier <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5a0840b767cd6443e8fd4aa02746ea6ca03c24bc Modified Files -------------- src/backend/optimizer/util/clauses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO @ 2025-04-01 22:58 David Rowley <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: David Rowley @ 2025-04-01 22:58 UTC (permalink / raw) To: [email protected] Fix planner's failure to identify multiple hashable ScalarArrayOpExprs 50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify IN and NOT IN clauses which have Const lists as right-hand arguments and when an appropriate hash function is available for the data types, mark the ScalarArrayOpExpr as hashable so the executor could execute it more optimally by building and probing a hash table during expression evaluation. These commits both worked correctly when there was only a single ScalarArrayOpExpr in the given expression being processed by the planner, but when there were multiple, only the first was checked and any subsequent ones were not identified, which resulted in less optimal expression evaluation during query execution for all but the first found ScalarArrayOpExpr. Backpatch to 14, where 50e17ad28 was introduced. Author: David Geier <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a7f213b11d92e7a6423821d041e283c4fde6ee5b Modified Files -------------- src/backend/optimizer/util/clauses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO @ 2025-04-01 22:58 David Rowley <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: David Rowley @ 2025-04-01 22:58 UTC (permalink / raw) To: [email protected] Fix planner's failure to identify multiple hashable ScalarArrayOpExprs 50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify IN and NOT IN clauses which have Const lists as right-hand arguments and when an appropriate hash function is available for the data types, mark the ScalarArrayOpExpr as hashable so the executor could execute it more optimally by building and probing a hash table during expression evaluation. These commits both worked correctly when there was only a single ScalarArrayOpExpr in the given expression being processed by the planner, but when there were multiple, only the first was checked and any subsequent ones were not identified, which resulted in less optimal expression evaluation during query execution for all but the first found ScalarArrayOpExpr. Backpatch to 14, where 50e17ad28 was introduced. Author: David Geier <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b68f664bb024330d33983b1e1f59f483bdd3aca1 Modified Files -------------- src/backend/optimizer/util/clauses.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-04-01 22:58 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-04-01 22:57 pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO David Rowley <[email protected]> 2025-04-01 22:57 pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO David Rowley <[email protected]> 2025-04-01 22:58 pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO David Rowley <[email protected]> 2025-04-01 22:58 pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO David Rowley <[email protected]> 2025-04-01 22:58 pgsql: Fix planner's failure to identify multiple hashable ScalarArrayO David Rowley <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox