public inbox for [email protected]
help / color / mirror / Atom feedFrom: Melanie Plageman <[email protected]>
To: [email protected]
Subject: pgsql: Remove misleading read stream asserts in a few users
Date: Thu, 03 Apr 2025 22:24:49 +0000
Message-ID: <[email protected]> (raw)
Remove misleading read stream asserts in a few users
Several read stream users asserted that the read stream was exhausted
after looping on that very condition. It was pointed out in an a
review of an as-of-yet uncommitted read stream user [1] that this was
confusing and could lead the reader to think there was a possibility of
some kind of race condition. Remove these asserts.
[1] https://postgr.es/m/F9ACE8D0-B807-4A17-B6BD-87EF0717983D%40yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/54a3615f15b9b2e1433bc47cfb150317885d7c1f
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 2 --
src/backend/access/gist/gistvacuum.c | 2 --
src/backend/access/nbtree/nbtree.c | 2 --
src/backend/access/spgist/spgvacuum.c | 2 --
4 files changed, 8 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Remove misleading read stream asserts in a few users
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox