public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Fix logical decoding regression tests to correctly check slot ex
6+ messages / 1 participants
[nested] [flat]
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:13 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:13 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c754bdd8a2e5ae388d48dc2a219f9f6b65e3ca3a
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:14 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:14 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5570e103bf84af8ce4c71d4fd49920673907bc7f
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:14 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:14 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bc485fce52ebaca3f2497f1f490dc9d42505946a
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:14 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:14 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/84fe9f1eb311423933fa9889a34e521c9ba18927
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:14 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:14 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0d22daad7e1a5abd16795590da54015aefb94848
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix logical decoding regression tests to correctly check slot ex
@ 2025-04-04 04:15 Fujii Masao <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Fujii Masao @ 2025-04-04 04:15 UTC (permalink / raw)
To: [email protected]
Fix logical decoding regression tests to correctly check slot existence.
The regression tests for logical decoding verify whether a logical slot
exists or has been dropped. Previously, these tests attempted to
retrieve "slot_name" from the result of slot(), but since "slot_name" was
not included in the result, slot()->{'slot_name'} always returned undef,
leading to incorrect behavior.
This commit fixes the issue by checking the "plugin" field in the result
of slot() instead, ensuring the tests properly verify slot existence.
Back-patch to all supported versions.
Author: Hayato Kuroda <[email protected]>
Reviewed-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/OSCPR01MB149667EC4E738769CA80B7EA5F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 13
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b29a183c67e1a41f1f77eff378d8c9f5409ee41c
Modified Files
--------------
src/test/recovery/t/006_logical_decoding.pl | 8 ++++----
src/test/recovery/t/010_logical_decoding_timelines.pl | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-04-04 04:15 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-04 04:13 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
2025-04-04 04:14 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
2025-04-04 04:14 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
2025-04-04 04:14 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
2025-04-04 04:14 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
2025-04-04 04:15 pgsql: Fix logical decoding regression tests to correctly check slot ex Fujii Masao <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox