pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle 3+ messages / 2 participants [nested] [flat]
* pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle @ 2021-06-29 01:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2021-06-29 01:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org In XLogFileInit(), fix *use_existent postcondition to suit callers. Infrequently, the mismatch caused log_checkpoints messages and TRACE_POSTGRESQL_CHECKPOINT_DONE() to witness an "added" count too high by one. Since that consequence is so minor, no back-patch. Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/85656bc3050f0846f53de95768b0f9f9df410560 Modified Files -------------- src/backend/access/transam/xlog.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle @ 2025-04-06 05:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 05:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org In XLogFileInit(), fix *use_existent postcondition to suit callers. Infrequently, the mismatch caused log_checkpoints messages and TRACE_POSTGRESQL_CHECKPOINT_DONE() to witness an "added" count too high by one. Since that consequence is so minor, no back-patch. This commit has been applied as of 85656bc3050f in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/20e5ef3ca70c3dd42a015af5296d9164079542d4 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle @ 2025-04-06 05:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 05:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org In XLogFileInit(), fix *use_existent postcondition to suit callers. Infrequently, the mismatch caused log_checkpoints messages and TRACE_POSTGRESQL_CHECKPOINT_DONE() to witness an "added" count too high by one. Since that consequence is so minor, no back-patch. This commit has been applied as of 85656bc3050f in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8967dddf086e81b0b5ee84a197cc2773f73e131a Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-06 05:45 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-06-29 01:36 pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle Noah Misch <noah@leadboat.com> 2025-04-06 05:45 pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle Michael Paquier <michael@paquier.xyz> 2025-04-06 05:45 pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox