pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom @ 2025-04-06 06:25 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-04-06 06:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Add HINT for restartpoint race with KeepFileRestoredFromArchive()." This reverts commit 8ad6c5dbbe5a, which was a commit specific to v14 and older branches as the race condition between restartpoints and KeepFileRestoredFromArchive() still existed. 1f95181b44c8 has worsened the situation on these two branches, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The same logic as v15 and newer versions will be applied in some follow-up commits to close this problem, making this HINT not necessary anymore. Reported-by: Arun Thirupathi Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47d2d29827293ed46f3641d8843ce5b5823d26e4 Modified Files -------------- src/backend/access/transam/xlog.c | 5 +---- src/backend/storage/file/fd.c | 10 ++-------- 2 files changed, 3 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom @ 2025-04-06 06:25 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-04-06 06:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Add HINT for restartpoint race with KeepFileRestoredFromArchive()." This reverts commit 8ad6c5dbbe5a, which was a commit specific to v14 and older branches as the race condition between restartpoints and KeepFileRestoredFromArchive() still existed. 1f95181b44c8 has worsened the situation on these two branches, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The same logic as v15 and newer versions will be applied in some follow-up commits to close this problem, making this HINT not necessary anymore. Reported-by: Arun Thirupathi Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e77d9cd4f52ec40ec9edc823ee89612ddf300795 Modified Files -------------- src/backend/access/transam/xlog.c | 5 +---- src/backend/storage/file/fd.c | 10 ++-------- 2 files changed, 3 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-04-06 06:25 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-04-06 06:25 pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom Michael Paquier <michael@paquier.xyz> 2025-04-06 06:25 pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox