pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Don't ERROR on PreallocXlogFiles() race condition. 3+ messages / 2 participants [nested] [flat]
* pgsql: Don't ERROR on PreallocXlogFiles() race condition. @ 2021-06-29 01:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2021-06-29 01:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't ERROR on PreallocXlogFiles() race condition. Before a restartpoint finishes PreallocXlogFiles(), a startup process KeepFileRestoredFromArchive() call can unlink the preallocated segment. If a CHECKPOINT sql command had elicited the restartpoint experiencing the race condition, that sql command failed. Moreover, the restartpoint omitted its log_checkpoints message and some inessential resource reclamation. Prevent the ERROR by skipping open() of the segment. Since these consequences are so minor, no back-patch. Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2b3e4672f7602a6bb46a0735a1b41b635508b290 Modified Files -------------- src/backend/access/transam/xlog.c | 79 +++++++++++++++++++++++++---------- src/backend/replication/walreceiver.c | 4 +- src/include/access/xlog.h | 2 +- 3 files changed, 58 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Don't ERROR on PreallocXlogFiles() race condition. @ 2025-04-06 06:37 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 06:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't ERROR on PreallocXlogFiles() race condition. Before a restartpoint finishes PreallocXlogFiles(), a startup process KeepFileRestoredFromArchive() call can unlink the preallocated segment. If a CHECKPOINT sql command had elicited the restartpoint experiencing the race condition, that sql command failed. Moreover, the restartpoint omitted its log_checkpoints message and some inessential resource reclamation. Prevent the ERROR by skipping open() of the segment. Since these consequences are so minor, no back-patch. This commit has been applied as of 2b3e4672f760 in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/675b771ca5f28bb38cf14151fb30ac28f2e1ca4b Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 79 +++++++++++++++++++++++++---------- src/backend/replication/walreceiver.c | 4 +- src/include/access/xlog.h | 2 +- 3 files changed, 58 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Don't ERROR on PreallocXlogFiles() race condition. @ 2025-04-06 06:37 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 06:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't ERROR on PreallocXlogFiles() race condition. Before a restartpoint finishes PreallocXlogFiles(), a startup process KeepFileRestoredFromArchive() call can unlink the preallocated segment. If a CHECKPOINT sql command had elicited the restartpoint experiencing the race condition, that sql command failed. Moreover, the restartpoint omitted its log_checkpoints message and some inessential resource reclamation. Prevent the ERROR by skipping open() of the segment. Since these consequences are so minor, no back-patch. This commit has been applied as of 2b3e4672f760 in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cbed472a93417abc0411b5c8a0ac4d20ec7f4911 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 79 +++++++++++++++++++++++++---------- src/backend/replication/walreceiver.c | 4 +- src/include/access/xlog.h | 2 +- 3 files changed, 58 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-06 06:37 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-06-29 01:36 pgsql: Don't ERROR on PreallocXlogFiles() race condition. Noah Misch <noah@leadboat.com> 2025-04-06 06:37 pgsql: Don't ERROR on PreallocXlogFiles() race condition. Michael Paquier <michael@paquier.xyz> 2025-04-06 06:37 pgsql: Don't ERROR on PreallocXlogFiles() race condition. Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox