pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Stabilize 035_standby_logical_decoding.pl. 3+ messages / 1 participants [nested] [flat]
* pgsql: Stabilize 035_standby_logical_decoding.pl. @ 2025-04-08 04:23 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2025-04-08 04:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize 035_standby_logical_decoding.pl. Some tests try to invalidate logical slots on the standby server by running VACUUM on the primary. The problem is that xl_running_xacts was getting generated and replayed before the VACUUM command, leading to the advancement of the active slot's catalog_xmin. Due to this, active slots were not getting invalidated, leading to test failures. We fix it by skipping the generation of xl_running_xacts for the required tests with the help of injection points. As the required interface for injection points was not present in back branches, we fixed the failing tests in them by disallowing the slot to become active for the required cases (where rows_removed conflict could be generated). Author: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 16, where it was introduced Discussion: https://postgr.es/m/Z6oQXc8LmiTLfwLA@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/86392e8827d874dd2adc4393ce7a962513620455 Modified Files -------------- .../recovery/t/035_standby_logical_decoding.pl | 49 +++++++++++++--------- 1 file changed, 29 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Stabilize 035_standby_logical_decoding.pl. @ 2025-04-08 04:23 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2025-04-08 04:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize 035_standby_logical_decoding.pl. Some tests try to invalidate logical slots on the standby server by running VACUUM on the primary. The problem is that xl_running_xacts was getting generated and replayed before the VACUUM command, leading to the advancement of the active slot's catalog_xmin. Due to this, active slots were not getting invalidated, leading to test failures. We fix it by skipping the generation of xl_running_xacts for the required tests with the help of injection points. As the required interface for injection points was not present in back branches, we fixed the failing tests in them by disallowing the slot to become active for the required cases (where rows_removed conflict could be generated). Author: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 16, where it was introduced Discussion: https://postgr.es/m/Z6oQXc8LmiTLfwLA@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/105b2cb336173d7c62e26ad104682175ddad4cff Modified Files -------------- src/backend/storage/ipc/standby.c | 12 +++++ .../recovery/t/035_standby_logical_decoding.pl | 56 ++++++++++++++++------ 2 files changed, 54 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Stabilize 035_standby_logical_decoding.pl. @ 2025-04-08 04:23 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2025-04-08 04:23 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize 035_standby_logical_decoding.pl. Some tests try to invalidate logical slots on the standby server by running VACUUM on the primary. The problem is that xl_running_xacts was getting generated and replayed before the VACUUM command, leading to the advancement of the active slot's catalog_xmin. Due to this, active slots were not getting invalidated, leading to test failures. We fix it by skipping the generation of xl_running_xacts for the required tests with the help of injection points. As the required interface for injection points was not present in back branches, we fixed the failing tests in them by disallowing the slot to become active for the required cases (where rows_removed conflict could be generated). Author: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 16, where it was introduced Discussion: https://postgr.es/m/Z6oQXc8LmiTLfwLA@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/17a165d60f734b3aa2e495d890f0c4b8324ca629 Modified Files -------------- .../recovery/t/035_standby_logical_decoding.pl | 64 ++++++++++------------ 1 file changed, 29 insertions(+), 35 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-08 04:23 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-04-08 04:23 pgsql: Stabilize 035_standby_logical_decoding.pl. Amit Kapila <akapila@postgresql.org> 2025-04-08 04:23 pgsql: Stabilize 035_standby_logical_decoding.pl. Amit Kapila <akapila@postgresql.org> 2025-04-08 04:23 pgsql: Stabilize 035_standby_logical_decoding.pl. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox