pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: doc:  clarify new behavior of max_files_per_process
4+ messages / 2 participants
[nested] [flat]

Commits from this thread:
  2025-04-29 faced8e6a4  doc:  adjust max_files_per_process again
* pgsql: doc:  clarify new behavior of max_files_per_process
@ 2025-04-29 13:45  Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Bruce Momjian @ 2025-04-29 13:45 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

doc:  clarify new behavior of max_files_per_process

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9a9e60fed39268bb85b59dde3cdb0b0166c85cc5

Modified Files
--------------
doc/src/sgml/config.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: doc:  clarify new behavior of max_files_per_process
@ 2025-04-29 13:52  Andres Freund <andres@anarazel.de>
  parent: Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 4+ messages in thread

From: Andres Freund @ 2025-04-29 13:52 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-committers@lists.postgresql.org

Hi,

On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote:
> doc:  clarify new behavior of max_files_per_process

I don't think this really is an improvement - if postmaster is called with a
bunch of files already opened, they aren't opened by postmaster, but still are
ignored...

Greetings,

Andres





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: doc:  clarify new behavior of max_files_per_process
@ 2025-04-29 14:26  Bruce Momjian <bruce@momjian.us>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 4+ messages in thread

From: Bruce Momjian @ 2025-04-29 14:26 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote:
> Hi,
> 
> On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote:
> > doc:  clarify new behavior of max_files_per_process
> 
> I don't think this really is an improvement - if postmaster is called with a
> bunch of files already opened, they aren't opened by postmaster, but still are
> ignored...

Okay, I was more objecting to the text that wasn't clear;  it was:

        Sets the maximum number of open files each server subprocess is
        allowed to open simultaneously, in addition to the files already
        open in postmaster. The default is one thousand files.

The "in addition" wasn't clear to me.  I could read it as "adding" the
postmaster file descriptors.  I changed it now to:

        Sets the maximum number of open files each server subprocess is
        allowed to open simultaneously;  files opened in the postmaster are
        not counted toward this limit. The default is one thousand files.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: doc:  clarify new behavior of max_files_per_process
@ 2025-04-29 14:29  Bruce Momjian <bruce@momjian.us>
  parent: Bruce Momjian <bruce@momjian.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Bruce Momjian @ 2025-04-29 14:29 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Apr 29, 2025 at 10:26:50AM -0400, Bruce Momjian wrote:
> On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote:
> > Hi,
> > 
> > On 2025-04-29 13:45:44 +0000, Bruce Momjian wrote:
> > > doc:  clarify new behavior of max_files_per_process
> > 
> > I don't think this really is an improvement - if postmaster is called with a
> > bunch of files already opened, they aren't opened by postmaster, but still are
> > ignored...
> 
> Okay, I was more objecting to the text that wasn't clear;  it was:
> 
>         Sets the maximum number of open files each server subprocess is
>         allowed to open simultaneously, in addition to the files already
>         open in postmaster. The default is one thousand files.
> 
> The "in addition" wasn't clear to me.  I could read it as "adding" the
> postmaster file descriptors.  I changed it now to:
> 
>         Sets the maximum number of open files each server subprocess is
>         allowed to open simultaneously;  files opened in the postmaster are
>         not counted toward this limit. The default is one thousand files.

I ended up preserving your "already" too:

        Sets the maximum number of open files each server subprocess
        is allowed to open simultaneously;  files already opened in the
        postmaster are not counted toward this limit. The default is one
        thousand files.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2025-04-29 14:29 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-29 13:45 pgsql: doc:  clarify new behavior of max_files_per_process Bruce Momjian <bruce@momjian.us>
2025-04-29 13:52 ` Andres Freund <andres@anarazel.de>
2025-04-29 14:26   ` Bruce Momjian <bruce@momjian.us>
2025-04-29 14:29     ` Bruce Momjian <bruce@momjian.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox