pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove unused check in heap_xlog_insert() 5+ messages / 1 participants [nested] [flat]
* pgsql: Remove unused check in heap_xlog_insert() @ 2025-06-26 19:08 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Melanie Plageman @ 2025-06-26 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ%3DEx6PKxv0o8y2GvA%40mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/483f7246f39b3af250fed1e613d962b85b568861 Modified Files -------------- src/backend/access/heap/heapam_xlog.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove unused check in heap_xlog_insert() @ 2025-06-26 19:08 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Melanie Plageman @ 2025-06-26 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ%3DEx6PKxv0o8y2GvA%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/40c9b4d8dafc7e573df1f783d22be292a0ed323b Modified Files -------------- src/backend/access/heap/heapam.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove unused check in heap_xlog_insert() @ 2025-06-26 19:08 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Melanie Plageman @ 2025-06-26 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ%3DEx6PKxv0o8y2GvA%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/13a449fc5d4896452958fd4aa5b007aa24c0287f Modified Files -------------- src/backend/access/heap/heapam.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove unused check in heap_xlog_insert() @ 2025-06-26 19:08 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Melanie Plageman @ 2025-06-26 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ%3DEx6PKxv0o8y2GvA%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/98dd121fc8fce85da3ad20382fe3deb1586f9cb1 Modified Files -------------- src/backend/access/heap/heapam.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove unused check in heap_xlog_insert() @ 2025-06-26 19:08 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Melanie Plageman @ 2025-06-26 19:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. Author: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ%3DEx6PKxv0o8y2GvA%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5a24c20c8442168fd75ff878eb6f99026a31b58b Modified Files -------------- src/backend/access/heap/heapam.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-06-26 19:08 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-06-26 19:08 pgsql: Remove unused check in heap_xlog_insert() Melanie Plageman <melanieplageman@gmail.com> 2025-06-26 19:08 pgsql: Remove unused check in heap_xlog_insert() Melanie Plageman <melanieplageman@gmail.com> 2025-06-26 19:08 pgsql: Remove unused check in heap_xlog_insert() Melanie Plageman <melanieplageman@gmail.com> 2025-06-26 19:08 pgsql: Remove unused check in heap_xlog_insert() Melanie Plageman <melanieplageman@gmail.com> 2025-06-26 19:08 pgsql: Remove unused check in heap_xlog_insert() Melanie Plageman <melanieplageman@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox