pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages 2+ messages / 1 participants [nested] [flat]
* pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages @ 2025-07-01 10:59 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2025-07-01 10:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages Querying the NUMA status can be quite time consuming, especially with large shared buffers. 8cc139bec34a called numa_move_pages() once, for all buffers, and we had to wait for the syscall to complete. But with the chunking, introduced by 7fe2f67c7c to work around a kernel bug, we can do CHECK_FOR_INTERRUPTS() after each chunk, allowing users to abort the execution. Reviewed-by: Christoph Berg <myon@debian.org> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/aEtDozLmtZddARdB@msg.df7cb.de Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bf1119d74a79b68d9c9086e5d32d44fb294a1427 Modified Files -------------- src/port/pg_numa.c | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages @ 2025-07-01 10:59 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2025-07-01 10:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages Querying the NUMA status can be quite time consuming, especially with large shared buffers. 8cc139bec34a called numa_move_pages() once, for all buffers, and we had to wait for the syscall to complete. But with the chunking, introduced by 7fe2f67c7c to work around a kernel bug, we can do CHECK_FOR_INTERRUPTS() after each chunk, allowing users to abort the execution. Reviewed-by: Christoph Berg <myon@debian.org> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/aEtDozLmtZddARdB@msg.df7cb.de Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/54ac4944c36f8f6cfc4deaa3f828118b564e1d3d Modified Files -------------- src/port/pg_numa.c | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-07-01 10:59 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-01 10:59 pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages Tomas Vondra <tomas.vondra@postgresql.org> 2025-07-01 10:59 pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox