pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2025-07-03 81a2625eb2 Fix broken XML
* pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
@ 2025-07-03 09:30 Álvaro Herrera <alvherre@kurilemu.de>
2025-07-03 12:03 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 4+ messages in thread
From: Álvaro Herrera @ 2025-07-03 09:30 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
If certain constraint characteristic clauses (NO INHERIT, NOT VALID, NOT
ENFORCED) are given to CREATE CONSTRAINT TRIGGER, the resulting error
message is
ERROR: TRIGGER constraints cannot be marked NO INHERIT
which is a bit silly, because these aren't "constraints of type
TRIGGER". Hardcode a better error message to prevent it. This is a
cosmetic fix for quite a fringe problem with no known complaints from
users, so no backpatch.
While at it, silently accept ENFORCED if given.
Author: Amul Sul <sulamul@gmail.com>
Reviewed-by: jian he <jian.universality@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/CAAJ_b97hd-jMTS7AjgU6TDBCzDx_KyuKxG+K-DtYmOieg+giyQ@mail.gmail.com
Discussion: https://postgr.es/m/CACJufxHSp2puxP=q8ZtUGL1F+heapnzqFBZy5ZNGUjUgwjBqTQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/87251e114967d668c8f90ed9fb8c8a8834c2d288
Modified Files
--------------
doc/src/sgml/ref/create_trigger.sgml | 9 ++++++++-
src/backend/parser/gram.y | 22 +++++++++++++++++++++-
src/test/regress/expected/triggers.out | 23 ++++++++++++++++++++++-
src/test/regress/sql/triggers.sql | 15 ++++++++++++++-
4 files changed, 65 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
2025-07-03 09:30 pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
@ 2025-07-03 12:03 ` Daniel Gustafsson <daniel@yesql.se>
2025-07-03 14:32 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Gustafsson @ 2025-07-03 12:03 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; +Cc: pgsql-committers@lists.postgresql.org
> On 3 Jul 2025, at 11:30, Álvaro Herrera <alvherre@kurilemu.de> wrote:
alabio seems unhappy, and the hunk below seems to be culprit, it should closed
with a </varlistentry> right?
> doc/src/sgml/ref/create_trigger.sgml | 9 ++++++++-
+ <varlistentry>
+ <term><literal>ENFORCED</literal></term>
+ <listitem>
+ This is a noise word. Constraint triggers are always enforced.
+ </listitem>
+ </varlistitem>
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
2025-07-03 09:30 pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
2025-07-03 12:03 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Daniel Gustafsson <daniel@yesql.se>
@ 2025-07-03 14:32 ` Álvaro Herrera <alvherre@kurilemu.de>
2025-07-05 14:57 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Álvaro Herrera @ 2025-07-03 14:32 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-committers@lists.postgresql.org
On 2025-Jul-03, Daniel Gustafsson wrote:
> > On 3 Jul 2025, at 11:30, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> alabio seems unhappy, and the hunk below seems to be culprit, it should closed
> with a </varlistentry> right?
Thanks for pointing this out. Yeah, not only I used the wrong tag, but
it's also missing the wrapping <para> around the text. Should be fixed
now.
It turns out our meson port doesn't have the equivalent of a
"make -C doc/src/sgml check". Sigh. Back to configure again for me ...
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Industry suffers from the managerial dogma that for the sake of stability
and continuity, the company should be independent of the competence of
individual employees." (E. Dijkstra)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
2025-07-03 09:30 pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
2025-07-03 12:03 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Daniel Gustafsson <daniel@yesql.se>
2025-07-03 14:32 ` Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
@ 2025-07-05 14:57 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: David G. Johnston @ 2025-07-05 14:57 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; +Cc: Daniel Gustafsson <daniel@yesql.se>; pgsql-committers@lists.postgresql.org <pgsql-committers@lists.postgresql.org>
On Thursday, July 3, 2025, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> It turns out our meson port doesn't have the equivalent of a
> "make -C doc/src/sgml check". Sigh. Back to configure again for me ...
>
>
It could if someone wants to push this or something similar.
https://www.postgresql.org/message-id/87msoyhk9l.fsf@wibble.ilmari.org
David J.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-07-05 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-03 09:30 pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error Álvaro Herrera <alvherre@kurilemu.de>
2025-07-03 12:03 ` Daniel Gustafsson <daniel@yesql.se>
2025-07-03 14:32 ` Álvaro Herrera <alvherre@kurilemu.de>
2025-07-05 14:57 ` David G. Johnston <david.g.johnston@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox