pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_dump: Fix object-type sort priority for large objects. 3+ messages / 1 participants [nested] [flat]
* pgsql: pg_dump: Fix object-type sort priority for large objects. @ 2025-07-10 20:54 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Nathan Bossart @ 2025-07-10 20:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix object-type sort priority for large objects. Commit a45c78e328 moved large object metadata from SECTION_PRE_DATA to SECTION_DATA but neglected to move PRIO_LARGE_OBJECT in dbObjectTypePriorities accordingly. While this hasn't produced any known live bugs, it causes problems for a proposed patch that optimizes upgrades with many large objects. Fixing the priority might also make the topological sort step marginally faster by reducing the number of ordering violations that have to be fixed. Reviewed-by: Nitin Motiani <nitinmotiani@google.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathan Discussion: https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathan Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/fb6c860bbd1f798dc637c8aa8972570b84f01ad2 Modified Files -------------- src/bin/pg_dump/pg_dump_sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: pg_dump: Fix object-type sort priority for large objects. @ 2025-07-10 20:54 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Nathan Bossart @ 2025-07-10 20:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix object-type sort priority for large objects. Commit a45c78e328 moved large object metadata from SECTION_PRE_DATA to SECTION_DATA but neglected to move PRIO_LARGE_OBJECT in dbObjectTypePriorities accordingly. While this hasn't produced any known live bugs, it causes problems for a proposed patch that optimizes upgrades with many large objects. Fixing the priority might also make the topological sort step marginally faster by reducing the number of ordering violations that have to be fixed. Reviewed-by: Nitin Motiani <nitinmotiani@google.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathan Discussion: https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathan Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e43fae199e5068914c6cc39aff9dbbb65aa896d7 Modified Files -------------- src/bin/pg_dump/pg_dump_sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: pg_dump: Fix object-type sort priority for large objects. @ 2025-07-10 20:54 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Nathan Bossart @ 2025-07-10 20:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix object-type sort priority for large objects. Commit a45c78e328 moved large object metadata from SECTION_PRE_DATA to SECTION_DATA but neglected to move PRIO_LARGE_OBJECT in dbObjectTypePriorities accordingly. While this hasn't produced any known live bugs, it causes problems for a proposed patch that optimizes upgrades with many large objects. Fixing the priority might also make the topological sort step marginally faster by reducing the number of ordering violations that have to be fixed. Reviewed-by: Nitin Motiani <nitinmotiani@google.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathan Discussion: https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathan Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/36026b0fe3abb33f49477f2474e1f7b3f0fdf3d2 Modified Files -------------- src/bin/pg_dump/pg_dump_sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-07-10 20:54 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-10 20:54 pgsql: pg_dump: Fix object-type sort priority for large objects. Nathan Bossart <nathan@postgresql.org> 2025-07-10 20:54 pgsql: pg_dump: Fix object-type sort priority for large objects. Nathan Bossart <nathan@postgresql.org> 2025-07-10 20:54 pgsql: pg_dump: Fix object-type sort priority for large objects. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox