pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: oauth: Run Autoconf tests with correct compiler flags 2+ messages / 1 participants [nested] [flat]
* pgsql: oauth: Run Autoconf tests with correct compiler flags @ 2025-07-11 17:32 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-07-11 17:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth: Run Autoconf tests with correct compiler flags Commit b0635bfda split off the CPPFLAGS/LDFLAGS/LDLIBS for libcurl into their own separate Makefile variables, but I neglected to move the existing AC_CHECKs for Curl into a place where they would make use of those variables. They instead tested the system libcurl, which 1) is unhelpful if a different Curl is being used for the build and 2) will fail the build entirely if no system libcurl exists. Correct the order of operations here. Reported-by: Ivan Kush <ivan.kush@tantorlabs.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Ivan Kush <ivan.kush@tantorlabs.com> Discussion: https://postgr.es/m/8a611028-51a1-408c-b592-832e2e6e1fc9%40tantorlabs.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/990571a08b66c76be85b077ddcba419fd4524952 Modified Files -------------- config/programs.m4 | 18 ++++++++++++------ configure | 18 ++++++++++++------ 2 files changed, 24 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: oauth: Run Autoconf tests with correct compiler flags @ 2025-07-11 17:32 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-07-11 17:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth: Run Autoconf tests with correct compiler flags Commit b0635bfda split off the CPPFLAGS/LDFLAGS/LDLIBS for libcurl into their own separate Makefile variables, but I neglected to move the existing AC_CHECKs for Curl into a place where they would make use of those variables. They instead tested the system libcurl, which 1) is unhelpful if a different Curl is being used for the build and 2) will fail the build entirely if no system libcurl exists. Correct the order of operations here. Reported-by: Ivan Kush <ivan.kush@tantorlabs.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Ivan Kush <ivan.kush@tantorlabs.com> Discussion: https://postgr.es/m/8a611028-51a1-408c-b592-832e2e6e1fc9%40tantorlabs.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3d23f68c5529b5a38c6f38ebd8fae518b5a369d0 Modified Files -------------- config/programs.m4 | 18 ++++++++++++------ configure | 18 ++++++++++++------ 2 files changed, 24 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-07-11 17:32 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-11 17:32 pgsql: oauth: Run Autoconf tests with correct compiler flags Jacob Champion <jchampion@postgresql.org> 2025-07-11 17:32 pgsql: oauth: Run Autoconf tests with correct compiler flags Jacob Champion <jchampion@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox