pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix dumping of comments on invalid constraints on domains
7+ messages / 1 participants
[nested] [flat]
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0858f0f96ebb891c8960994f023ed5a17b758a38
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/constraints.out | 4 ++++
src/test/regress/sql/constraints.sql | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/dca0e9693b71a3edd8c7956005af143bb5c59f1c
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/constraints.out | 4 ++++
src/test/regress/sql/constraints.sql | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d07bc7c2b3ca5454a036487f67870fa7fb73491c
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/constraints.out | 4 ++++
src/test/regress/sql/constraints.sql | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cef998ef8314ea88db15b66f21ac000c9d0c248c
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/constraints.out | 4 ++++
src/test/regress/sql/constraints.sql | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5a261c135d43857b3d614399bd6dd0c058dc6bbe
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/expected/constraints.out | 4 ++++
src/test/regress/sql/constraints.sql | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e04aca1c4d33020527dd343b48d9ffe575f3bbd7
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/input/constraints.source | 6 ++++++
src/test/regress/output/constraints.source | 4 ++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix dumping of comments on invalid constraints on domains
@ 2025-07-16 17:23 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 7+ messages in thread
From: Álvaro Herrera @ 2025-07-16 17:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix dumping of comments on invalid constraints on domains
We skip dumping constraints together with domains if they are invalid
('separate') so that they appear after data -- but their comments were
dumped together with the domain definition, which in effect leads to the
comment being dumped when the constraint does not yet exist. Delay
them in the same way.
Oversight in 7eca575d1c28; backpatch all the way back.
Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxF_C2pe6J_+nPr6C5jf5rQnbYP8XOKr4HM8yHZtp2aQqQ@mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/57949cea5af06ee20d04e225fca34d855518e47f
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 23 ++++++++++++++++++++++-
src/test/regress/input/constraints.source | 6 ++++++
src/test/regress/output/constraints.source | 4 ++++
3 files changed, 32 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-07-16 17:23 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
2025-07-16 17:23 pgsql: Fix dumping of comments on invalid constraints on domains Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox