pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove assertion from PortalRunMulti
9+ messages / 2 participants
[nested] [flat]
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b8926a5b4bb82e3c56855185da4106d24d26154c
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e0d3f3cfb6f23b46bab89b8d9e8d82cbed951f80
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 16:11 ` Re: pgsql: Remove assertion from PortalRunMulti Aleksander Alekseev <aleksander@tigerdata.com>
0 siblings, 1 reply; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0c466f5e0b34bb9ddc53a422e9872b726f5f9620
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgsql: Remove assertion from PortalRunMulti
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
@ 2025-07-17 16:11 ` Aleksander Alekseev <aleksander@tigerdata.com>
2025-07-17 16:57 ` Re: pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 1 reply; 9+ messages in thread
From: Aleksander Alekseev @ 2025-07-17 16:11 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org; +Cc: Álvaro Herrera <alvherre@kurilemu.de>
Hi Avaro,
> Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
I didn't report this issue, it was done by Alexander Lakhin.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgsql: Remove assertion from PortalRunMulti
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 16:11 ` Re: pgsql: Remove assertion from PortalRunMulti Aleksander Alekseev <aleksander@tigerdata.com>
@ 2025-07-17 16:57 ` Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 16:57 UTC (permalink / raw)
To: Aleksander Alekseev <aleksander@tigerdata.com>; +Cc: pgsql-committers@lists.postgresql.org; exclusion@gmail.com
Hello,
On 2025-Jul-17, Aleksander Alekseev wrote:
> > Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
>
> I didn't report this issue, it was done by Alexander Lakhin.
Uh, you're right, my mistake -- apologies.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"How strange it is to find the words "Perl" and "saner" in such close
proximity, with no apparent sense of irony. I doubt that Larry himself
could have managed it." (ncm, http://lwn.net/Articles/174769/)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4871c1e9cb6e1a085f68c3c399dc4ba95d108524
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c2720ac6010a06427330b3b21ac5d3d012835da5
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b9a89682846f0dc47fef9d80219ba8fe0d9779c7
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: Remove assertion from PortalRunMulti
@ 2025-07-17 15:41 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Herrera @ 2025-07-17 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove assertion from PortalRunMulti
We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail. Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.
Oversight in 2f9661311b83. That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment. Remove that part,
and rewrite what remains for extra clarity.
Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/43cd8596275502c9e1da6024dedd90447535b371
Modified Files
--------------
src/backend/tcop/pquery.c | 25 ++++++++-----------------
1 file changed, 8 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2025-07-17 16:57 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 16:11 ` Aleksander Alekseev <aleksander@tigerdata.com>
2025-07-17 16:57 ` Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
2025-07-17 15:41 pgsql: Remove assertion from PortalRunMulti Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox