pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve the stability of the recovery test 047_checkpoint_physic 3+ messages / 1 participants [nested] [flat]
* pgsql: Improve the stability of the recovery test 047_checkpoint_physic @ 2025-07-19 12:45 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Alexander Korotkov @ 2025-07-19 12:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve the stability of the recovery test 047_checkpoint_physical_slot Currently, the comments in 047_checkpoint_physical_slot. It shows an incomplete intention to wait for checkpoint completion before performing an immediate database stop. However, an immediate node stop can occur both before and after checkpoint completion. Both cases should work correctly. But we would like the test to be more stable and deterministic. This is why this commit makes this test explicitly wait for the checkpoint completion log message. Discussion: https://postgr.es/m/CAPpHfdurV-j_e0pb%3DUFENAy3tyzxfF%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov <akorotkov@postgresql.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ccd945159361981d4d1583d2eccf81ddddd63fa5 Modified Files -------------- src/test/recovery/t/047_checkpoint_physical_slot.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve the stability of the recovery test 047_checkpoint_physic @ 2025-07-19 12:45 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Alexander Korotkov @ 2025-07-19 12:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve the stability of the recovery test 047_checkpoint_physical_slot Currently, the comments in 047_checkpoint_physical_slot. It shows an incomplete intention to wait for checkpoint completion before performing an immediate database stop. However, an immediate node stop can occur both before and after checkpoint completion. Both cases should work correctly. But we would like the test to be more stable and deterministic. This is why this commit makes this test explicitly wait for the checkpoint completion log message. Discussion: https://postgr.es/m/CAPpHfdurV-j_e0pb%3DUFENAy3tyzxfF%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov <akorotkov@postgresql.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c71c702f067b9191332c07acadd2297a42915e5f Modified Files -------------- src/test/recovery/t/047_checkpoint_physical_slot.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Improve the stability of the recovery test 047_checkpoint_physic @ 2025-07-19 12:45 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Alexander Korotkov @ 2025-07-19 12:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve the stability of the recovery test 047_checkpoint_physical_slot Currently, the comments in 047_checkpoint_physical_slot. It shows an incomplete intention to wait for checkpoint completion before performing an immediate database stop. However, an immediate node stop can occur both before and after checkpoint completion. Both cases should work correctly. But we would like the test to be more stable and deterministic. This is why this commit makes this test explicitly wait for the checkpoint completion log message. Discussion: https://postgr.es/m/CAPpHfdurV-j_e0pb%3DUFENAy3tyzxfF%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov <akorotkov@postgresql.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fd39c3cf28396d1fbb8b2a2cdb9fe66b6ad87964 Modified Files -------------- src/test/recovery/t/047_checkpoint_physical_slot.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-07-19 12:45 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-19 12:45 pgsql: Improve the stability of the recovery test 047_checkpoint_physic Alexander Korotkov <akorotkov@postgresql.org> 2025-07-19 12:45 pgsql: Improve the stability of the recovery test 047_checkpoint_physic Alexander Korotkov <akorotkov@postgresql.org> 2025-07-19 12:45 pgsql: Improve the stability of the recovery test 047_checkpoint_physic Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox