pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_dump: include comments on not-null constraints on domains, to 3+ messages / 1 participants [nested] [flat]
* pgsql: pg_dump: include comments on not-null constraints on domains, to @ 2025-07-21 09:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 3+ messages in thread From: Álvaro Herrera @ 2025-07-21 09:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: include comments on not-null constraints on domains, too Commit e5da0fe3c22b introduced catalog entries for not-null constraints on domains; but because commit b0e96f311985 (the original work for catalogued not-null constraints on tables) forgot to teach pg_dump to process the comments for them, this one also forgot. Add that now. We also need to teach repairDependencyLoop() about the new type of constraints being possible for domains. Backpatch-through: 17 Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxF-0bqVR=j4jonS6N2Ka6hHUpFyu3_3TWKNhOW_4yFSSg@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f9545e95c5e7ead0c19676ef8c966eb21f573954 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 160 +++++++++++++++++++++++++++++---------- src/bin/pg_dump/pg_dump.h | 4 +- src/bin/pg_dump/pg_dump_sort.c | 15 ++-- src/bin/pg_dump/t/002_pg_dump.pl | 30 +++++++- 4 files changed, 160 insertions(+), 49 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: pg_dump: include comments on not-null constraints on domains, to @ 2025-07-21 09:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 3+ messages in thread From: Álvaro Herrera @ 2025-07-21 09:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: include comments on not-null constraints on domains, too Commit e5da0fe3c22b introduced catalog entries for not-null constraints on domains; but because commit b0e96f311985 (the original work for catalogued not-null constraints on tables) forgot to teach pg_dump to process the comments for them, this one also forgot. Add that now. We also need to teach repairDependencyLoop() about the new type of constraints being possible for domains. Backpatch-through: 17 Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxF-0bqVR=j4jonS6N2Ka6hHUpFyu3_3TWKNhOW_4yFSSg@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6b755d8d70b2ceffeb4798cbb6907d2704c2e6c4 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 160 +++++++++++++++++++++++++++++---------- src/bin/pg_dump/pg_dump.h | 4 +- src/bin/pg_dump/pg_dump_sort.c | 15 ++-- src/bin/pg_dump/t/002_pg_dump.pl | 30 +++++++- 4 files changed, 160 insertions(+), 49 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: pg_dump: include comments on not-null constraints on domains, to @ 2025-07-21 09:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 3+ messages in thread From: Álvaro Herrera @ 2025-07-21 09:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: include comments on not-null constraints on domains, too Commit e5da0fe3c22b introduced catalog entries for not-null constraints on domains; but because commit b0e96f311985 (the original work for catalogued not-null constraints on tables) forgot to teach pg_dump to process the comments for them, this one also forgot. Add that now. We also need to teach repairDependencyLoop() about the new type of constraints being possible for domains. Backpatch-through: 17 Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxF-0bqVR=j4jonS6N2Ka6hHUpFyu3_3TWKNhOW_4yFSSg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/da71717f0a7cf905a6a31ffd34552554922a0374 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 160 +++++++++++++++++++++++++++++---------- src/bin/pg_dump/pg_dump.h | 4 +- src/bin/pg_dump/pg_dump_sort.c | 15 ++-- src/bin/pg_dump/t/002_pg_dump.pl | 30 +++++++- 4 files changed, 160 insertions(+), 49 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-07-21 09:35 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-21 09:35 pgsql: pg_dump: include comments on not-null constraints on domains, to Álvaro Herrera <alvherre@kurilemu.de> 2025-07-21 09:35 pgsql: pg_dump: include comments on not-null constraints on domains, to Álvaro Herrera <alvherre@kurilemu.de> 2025-07-21 09:35 pgsql: pg_dump: include comments on not-null constraints on domains, to Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox