pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix assertion failure in pgbench when handling multiple pipeline
5+ messages / 1 participants
[nested] [flat]
* pgsql: Fix assertion failure in pgbench when handling multiple pipeline
@ 2025-08-03 01:53 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2025-08-03 01:53 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix assertion failure in pgbench when handling multiple pipeline sync messages.
Previously, when running pgbench in pipeline mode with a custom script
that triggered retriable errors (e.g., serialization errors),
an assertion failure could occur:
Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3515.
The root cause was that pgbench incorrectly assumed only a single
pipeline sync message would be received at the end. In reality,
multiple pipeline sync messages can be sent and must be handled properly.
This commit fixes the issue by updating pgbench to correctly process
multiple pipeline sync messages, preventing the assertion failure.
Back-patch to v15, where the bug was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAHGQGwFAX56Tfx+1ppo431OSWiLLuW72HaGzZ39NkLkop6bMzQ@mail.gmail.com
Backpatch-through: 15
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/12efa48978c6dba5eca1b95758127181783fb217
Modified Files
--------------
src/bin/pgbench/pgbench.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix assertion failure in pgbench when handling multiple pipeline
@ 2025-08-03 01:54 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2025-08-03 01:54 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix assertion failure in pgbench when handling multiple pipeline sync messages.
Previously, when running pgbench in pipeline mode with a custom script
that triggered retriable errors (e.g., serialization errors),
an assertion failure could occur:
Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3515.
The root cause was that pgbench incorrectly assumed only a single
pipeline sync message would be received at the end. In reality,
multiple pipeline sync messages can be sent and must be handled properly.
This commit fixes the issue by updating pgbench to correctly process
multiple pipeline sync messages, preventing the assertion failure.
Back-patch to v15, where the bug was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAHGQGwFAX56Tfx+1ppo431OSWiLLuW72HaGzZ39NkLkop6bMzQ@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fee46ab4f2440c835a18aa1fdfaebf6ceb85ae09
Modified Files
--------------
src/bin/pgbench/pgbench.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix assertion failure in pgbench when handling multiple pipeline
@ 2025-08-03 01:54 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2025-08-03 01:54 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix assertion failure in pgbench when handling multiple pipeline sync messages.
Previously, when running pgbench in pipeline mode with a custom script
that triggered retriable errors (e.g., serialization errors),
an assertion failure could occur:
Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3515.
The root cause was that pgbench incorrectly assumed only a single
pipeline sync message would be received at the end. In reality,
multiple pipeline sync messages can be sent and must be handled properly.
This commit fixes the issue by updating pgbench to correctly process
multiple pipeline sync messages, preventing the assertion failure.
Back-patch to v15, where the bug was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAHGQGwFAX56Tfx+1ppo431OSWiLLuW72HaGzZ39NkLkop6bMzQ@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/398e07162eca184c990c92fb69a50a993a723bb6
Modified Files
--------------
src/bin/pgbench/pgbench.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix assertion failure in pgbench when handling multiple pipeline
@ 2025-08-03 01:54 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2025-08-03 01:54 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix assertion failure in pgbench when handling multiple pipeline sync messages.
Previously, when running pgbench in pipeline mode with a custom script
that triggered retriable errors (e.g., serialization errors),
an assertion failure could occur:
Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3515.
The root cause was that pgbench incorrectly assumed only a single
pipeline sync message would be received at the end. In reality,
multiple pipeline sync messages can be sent and must be handled properly.
This commit fixes the issue by updating pgbench to correctly process
multiple pipeline sync messages, preventing the assertion failure.
Back-patch to v15, where the bug was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAHGQGwFAX56Tfx+1ppo431OSWiLLuW72HaGzZ39NkLkop6bMzQ@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1d3ded521a0be7f46dde132053d876ec1cad2784
Modified Files
--------------
src/bin/pgbench/pgbench.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix assertion failure in pgbench when handling multiple pipeline
@ 2025-08-03 01:55 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2025-08-03 01:55 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix assertion failure in pgbench when handling multiple pipeline sync messages.
Previously, when running pgbench in pipeline mode with a custom script
that triggered retriable errors (e.g., serialization errors),
an assertion failure could occur:
Assertion failed: (res == ((void*)0)), function discardUntilSync, file pgbench.c, line 3515.
The root cause was that pgbench incorrectly assumed only a single
pipeline sync message would be received at the end. In reality,
multiple pipeline sync messages can be sent and must be handled properly.
This commit fixes the issue by updating pgbench to correctly process
multiple pipeline sync messages, preventing the assertion failure.
Back-patch to v15, where the bug was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CAHGQGwFAX56Tfx+1ppo431OSWiLLuW72HaGzZ39NkLkop6bMzQ@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6914a330f019feab9fb90fc7d79c93e24ca3193f
Modified Files
--------------
src/bin/pgbench/pgbench.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-08-03 01:55 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-03 01:53 pgsql: Fix assertion failure in pgbench when handling multiple pipeline Fujii Masao <fujii@postgresql.org>
2025-08-03 01:54 pgsql: Fix assertion failure in pgbench when handling multiple pipeline Fujii Masao <fujii@postgresql.org>
2025-08-03 01:54 pgsql: Fix assertion failure in pgbench when handling multiple pipeline Fujii Masao <fujii@postgresql.org>
2025-08-03 01:54 pgsql: Fix assertion failure in pgbench when handling multiple pipeline Fujii Masao <fujii@postgresql.org>
2025-08-03 01:55 pgsql: Fix assertion failure in pgbench when handling multiple pipeline Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox