pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_upgrade: Make format strings consistent 4+ messages / 1 participants [nested] [flat]
* pgsql: pg_upgrade: Make format strings consistent @ 2025-08-07 22:33 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 4+ messages in thread From: Peter Eisentraut @ 2025-08-07 22:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_upgrade: Make format strings consistent The backport of commit f295494d338 introduced a format string using %m. This is not wrong, since those have been supported since commit d6c55de1f99a, but only commit 2c8118ee5d9 later introduced their use in this file. This use introduces a gratuitously different translatable string and also makes it inconsistent with the rest of the file. To avoid that, switch this back to the old-style strerror() route in the appropriate backbranches Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/06f44481646a669b43a19a2c501a164459d194f1 Modified Files -------------- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_upgrade: Make format strings consistent @ 2025-08-07 22:33 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 4+ messages in thread From: Peter Eisentraut @ 2025-08-07 22:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_upgrade: Make format strings consistent The backport of commit f295494d338 introduced a format string using %m. This is not wrong, since those have been supported since commit d6c55de1f99a, but only commit 2c8118ee5d9 later introduced their use in this file. This use introduces a gratuitously different translatable string and also makes it inconsistent with the rest of the file. To avoid that, switch this back to the old-style strerror() route in the appropriate backbranches Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a8b31b160bf643a4a7f590a4375d5d268152bda6 Modified Files -------------- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_upgrade: Make format strings consistent @ 2025-08-07 22:33 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 4+ messages in thread From: Peter Eisentraut @ 2025-08-07 22:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_upgrade: Make format strings consistent The backport of commit f295494d338 introduced a format string using %m. This is not wrong, since those have been supported since commit d6c55de1f99a, but only commit 2c8118ee5d9 later introduced their use in this file. This use introduces a gratuitously different translatable string and also makes it inconsistent with the rest of the file. To avoid that, switch this back to the old-style strerror() route in the appropriate backbranches Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ed2bb0cdda7764a95d6e1e4019417a7857b6f002 Modified Files -------------- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_upgrade: Make format strings consistent @ 2025-08-07 22:33 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 4+ messages in thread From: Peter Eisentraut @ 2025-08-07 22:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_upgrade: Make format strings consistent The backport of commit f295494d338 introduced a format string using %m. This is not wrong, since those have been supported since commit d6c55de1f99a, but only commit 2c8118ee5d9 later introduced their use in this file. This use introduces a gratuitously different translatable string and also makes it inconsistent with the rest of the file. To avoid that, switch this back to the old-style strerror() route in the appropriate backbranches Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/de7fd83cda925f59a078890d177cb32cbfb0a965 Modified Files -------------- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-08-07 22:33 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-07 22:33 pgsql: pg_upgrade: Make format strings consistent Peter Eisentraut <peter@eisentraut.org> 2025-08-07 22:33 pgsql: pg_upgrade: Make format strings consistent Peter Eisentraut <peter@eisentraut.org> 2025-08-07 22:33 pgsql: pg_upgrade: Make format strings consistent Peter Eisentraut <peter@eisentraut.org> 2025-08-07 22:33 pgsql: pg_upgrade: Make format strings consistent Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox