pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix rare bug in read_stream.c's split IO handling.
2+ messages / 1 participants
[nested] [flat]

* pgsql: Fix rare bug in read_stream.c's split IO handling.
@ 2025-08-09 01:26  Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Thomas Munro @ 2025-08-09 01:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix rare bug in read_stream.c's split IO handling.

The internal queue of buffers could become corrupted in a rare edge case
that failed to invalidate an entry, causing a stale buffer to be
"forwarded" to StartReadBuffers().  This is a simple fix for the
immediate problem.

A small API change might be able to remove this and related fragility
entirely, but that will have to wait a bit.

Defect in commit ed0b87ca.

Bug: 19006
Backpatch-through: 18
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/19006-80fcaaf69000377e%40postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b421223172a28db2e724d5e35304097fe68a1e38

Modified Files
--------------
src/backend/storage/aio/read_stream.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix rare bug in read_stream.c's split IO handling.
@ 2025-08-09 01:26  Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Thomas Munro @ 2025-08-09 01:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix rare bug in read_stream.c's split IO handling.

The internal queue of buffers could become corrupted in a rare edge case
that failed to invalidate an entry, causing a stale buffer to be
"forwarded" to StartReadBuffers().  This is a simple fix for the
immediate problem.

A small API change might be able to remove this and related fragility
entirely, but that will have to wait a bit.

Defect in commit ed0b87ca.

Bug: 19006
Backpatch-through: 18
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/19006-80fcaaf69000377e%40postgresql.org

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9110d81641696b95ea55f3a15dd0907ec0743529

Modified Files
--------------
src/backend/storage/aio/read_stream.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-08-09 01:26 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-09 01:26 pgsql: Fix rare bug in read_stream.c's split IO handling. Thomas Munro <tmunro@postgresql.org>
2025-08-09 01:26 pgsql: Fix rare bug in read_stream.c's split IO handling. Thomas Munro <tmunro@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox