pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling 4+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling @ 2025-08-13 04:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-08-13 04:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix tests with ANALYZE and remote sampling The tests fixed in this commit were changing the sampling setting of a foreign server, but then were analyzing a local table instead of a foreign table, meaning that the test was not running for its original purpose. This commit changes the ANALYZE commands to analyze the foreign table, and changes the foreign table definition to point to a valid remote table. Attempting to analyze the foreign table "analyze_ftable" would have failed before this commit, because "analyze_rtable1" is not defined on the remote side. Issue introduced by 8ad51b5f446b. Author: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CADkLM=cpUiJ3QF7aUthTvaVMmgQcm7QqZBRMDLhBRTR+gJX-Og@mail.gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/783cbb6d5e8bdf87d321286f210983c177ead967 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 12 ++++++------ contrib/postgres_fdw/sql/postgres_fdw.sql | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling @ 2025-08-13 04:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-08-13 04:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix tests with ANALYZE and remote sampling The tests fixed in this commit were changing the sampling setting of a foreign server, but then were analyzing a local table instead of a foreign table, meaning that the test was not running for its original purpose. This commit changes the ANALYZE commands to analyze the foreign table, and changes the foreign table definition to point to a valid remote table. Attempting to analyze the foreign table "analyze_ftable" would have failed before this commit, because "analyze_rtable1" is not defined on the remote side. Issue introduced by 8ad51b5f446b. Author: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CADkLM=cpUiJ3QF7aUthTvaVMmgQcm7QqZBRMDLhBRTR+gJX-Og@mail.gmail.com Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2102667b3c1ba6dbc65fcbe687cccb578772a5e9 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 12 ++++++------ contrib/postgres_fdw/sql/postgres_fdw.sql | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling @ 2025-08-13 04:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-08-13 04:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix tests with ANALYZE and remote sampling The tests fixed in this commit were changing the sampling setting of a foreign server, but then were analyzing a local table instead of a foreign table, meaning that the test was not running for its original purpose. This commit changes the ANALYZE commands to analyze the foreign table, and changes the foreign table definition to point to a valid remote table. Attempting to analyze the foreign table "analyze_ftable" would have failed before this commit, because "analyze_rtable1" is not defined on the remote side. Issue introduced by 8ad51b5f446b. Author: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CADkLM=cpUiJ3QF7aUthTvaVMmgQcm7QqZBRMDLhBRTR+gJX-Og@mail.gmail.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e81a5031d51f9cd68adb7bdccc424880bac6838e Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 12 ++++++------ contrib/postgres_fdw/sql/postgres_fdw.sql | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling @ 2025-08-13 04:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2025-08-13 04:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix tests with ANALYZE and remote sampling The tests fixed in this commit were changing the sampling setting of a foreign server, but then were analyzing a local table instead of a foreign table, meaning that the test was not running for its original purpose. This commit changes the ANALYZE commands to analyze the foreign table, and changes the foreign table definition to point to a valid remote table. Attempting to analyze the foreign table "analyze_ftable" would have failed before this commit, because "analyze_rtable1" is not defined on the remote side. Issue introduced by 8ad51b5f446b. Author: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CADkLM=cpUiJ3QF7aUthTvaVMmgQcm7QqZBRMDLhBRTR+gJX-Og@mail.gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/327bd6111aede2a41f8891d2cd2501c773bc047e Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 12 ++++++------ contrib/postgres_fdw/sql/postgres_fdw.sql | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-08-13 04:12 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-13 04:12 pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling Michael Paquier <michael@paquier.xyz> 2025-08-13 04:12 pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling Michael Paquier <michael@paquier.xyz> 2025-08-13 04:12 pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling Michael Paquier <michael@paquier.xyz> 2025-08-13 04:12 pgsql: postgres_fdw: Fix tests with ANALYZE and remote sampling Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox